bpo-36745: Fix a possible reference leak in PyObject_SetAttr() (GH-12993)

https://bugs.python.org/issue36745

bpo-36745: Fix a possible reference leak in PyObject_SetAttr() (GH-12993)
https://bugs.python.org/issue36745
e0dcb85b · Zackery Spytz · Miss Islington (bot) · da63b321 · e0dcb85b
Commit e0dcb85b authored Apr 28, 2019 by Zackery Spytz Committed by Miss Islington (bot) Apr 28, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

Objects/object.c Objects/object.c +3 -1

No files found.
--- a/Objects/object.c
+++ b/Objects/object.c
@@ -1044,8 +1044,10 @@ PyObject_SetAttr(PyObject *v, PyObject *name, PyObject *value)
    }
    if (tp->tp_setattr != NULL) {
        const char *name_str = PyUnicode_AsUTF8(name);
-        if (name_str == NULL)
+        if (name_str == NULL) {
+            Py_DECREF(name);
            return -1;
+        }
        err = (*tp->tp_setattr)(v, (char *)name_str, value);
        Py_DECREF(name);
        return err;