Commit e10d6e07 authored by Gregory P. Smith's avatar Gregory P. Smith

Fixes Issue #17200: telnetlib's read_until and expect timeout was broken by the

fix to Issue #14635 in Python 3.3.0 to be interpreted as milliseconds instead
of seconds when the platform supports select.poll (ie: everywhere).  It is now
treated as seconds once again.
parent a48861a9
...@@ -315,7 +315,8 @@ class Telnet: ...@@ -315,7 +315,8 @@ class Telnet:
poller.register(self, poll_in_or_priority_flags) poller.register(self, poll_in_or_priority_flags)
while i < 0 and not self.eof: while i < 0 and not self.eof:
try: try:
ready = poller.poll(call_timeout) ready = poller.poll(None if timeout is None
else 1000 * call_timeout)
except select.error as e: except select.error as e:
if e.errno == errno.EINTR: if e.errno == errno.EINTR:
if timeout is not None: if timeout is not None:
...@@ -683,7 +684,8 @@ class Telnet: ...@@ -683,7 +684,8 @@ class Telnet:
poller.register(self, poll_in_or_priority_flags) poller.register(self, poll_in_or_priority_flags)
while not m and not self.eof: while not m and not self.eof:
try: try:
ready = poller.poll(call_timeout) ready = poller.poll(None if timeout is None
else 1000 * call_timeout)
except select.error as e: except select.error as e:
if e.errno == errno.EINTR: if e.errno == errno.EINTR:
if timeout is not None: if timeout is not None:
......
...@@ -20,6 +20,11 @@ Core and Builtins ...@@ -20,6 +20,11 @@ Core and Builtins
Library Library
------- -------
- Issue #17200: telnetlib's read_until and expect timeout was broken by the
fix to Issue #14635 in Python 3.3.0 to be interpreted as milliseconds
instead of seconds when the platform supports select.poll (ie: everywhere).
It is now treated as seconds once again.
- Issue #17429: platform.linux_distribution() now decodes files from the UTF-8 - Issue #17429: platform.linux_distribution() now decodes files from the UTF-8
encoding with the surrogateescape error handler, instead of decoding from the encoding with the surrogateescape error handler, instead of decoding from the
locale encoding in strict mode. It fixes the function on Fedora 19 which is locale encoding in strict mode. It fixes the function on Fedora 19 which is
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment