Micro-optimization for list_contains. Factored double if test

out of the loop.

Micro-optimization for list_contains. Factored double if test
out of the loop.
e45fcd87 · Raymond Hettinger · 0aa581b8 · e45fcd87
Commit e45fcd87 authored Sep 05, 2002 by Raymond Hettinger
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 7 deletions

Objects/tupleobject.c Objects/tupleobject.c +6 -7

No files found.
--- a/Objects/tupleobject.c
+++ b/Objects/tupleobject.c
@@ -263,14 +263,13 @@ tuplecontains(PyTupleObject *a, PyObject *el)
 {
 	int i, cmp;
-	for (i = 0; i < a->ob_size; ++i) {
+	for (i = 0, cmp = 0 ; cmp == 0 && i < a->ob_size; ++i)
 		cmp = PyObject_RichCompareBool(el, PyTuple_GET_ITEM(a, i),
-					       Py_EQ);
+						   Py_EQ);
-		if (cmp > 0)
+	if (cmp > 0)
-			return 1;
+		return 1;
-		else if (cmp < 0)
+	if (cmp < 0)
-			return -1;
+		return -1;
-	}
 	return 0;
 }