Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
e4dcbbd7
Commit
e4dcbbd7
authored
Aug 07, 2018
by
Berker Peksag
Committed by
GitHub
Aug 07, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
bpo-18540: Fix EAI_NONAME in imaplib.IMAP4*() (GH-8634)
parent
3c1b5904
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
22 additions
and
1 deletion
+22
-1
Lib/imaplib.py
Lib/imaplib.py
+5
-1
Lib/test/test_imaplib.py
Lib/test/test_imaplib.py
+14
-0
Misc/NEWS.d/next/Library/2018-08-02-21-28-38.bpo-18540.AryoYY.rst
...S.d/next/Library/2018-08-02-21-28-38.bpo-18540.AryoYY.rst
+3
-0
No files found.
Lib/imaplib.py
View file @
e4dcbbd7
...
...
@@ -282,7 +282,11 @@ class IMAP4:
def
_create_socket
(
self
):
return
socket
.
create_connection
((
self
.
host
,
self
.
port
))
# Default value of IMAP4.host is '', but socket.getaddrinfo()
# (which is used by socket.create_connection()) expects None
# as a default value for host.
host
=
None
if
not
self
.
host
else
self
.
host
return
socket
.
create_connection
((
host
,
self
.
port
))
def
open
(
self
,
host
=
''
,
port
=
IMAP4_PORT
):
"""Setup connection to remote server on "host:port"
...
...
Lib/test/test_imaplib.py
View file @
e4dcbbd7
from
test
import
support
from
contextlib
import
contextmanager
import
errno
import
imaplib
import
os.path
import
socketserver
...
...
@@ -69,6 +70,19 @@ class TestImaplib(unittest.TestCase):
for
t
in
self
.
timevalues
():
imaplib
.
Time2Internaldate
(
t
)
def
test_imap4_host_default_value
(
self
):
expected_errnos
=
[
# This is the exception that should be raised.
errno
.
ECONNREFUSED
,
]
if
hasattr
(
errno
,
'EADDRNOTAVAIL'
):
# socket.create_connection() fails randomly with
# EADDRNOTAVAIL on Travis CI.
expected_errnos
.
append
(
errno
.
EADDRNOTAVAIL
)
with
self
.
assertRaises
(
OSError
)
as
cm
:
imaplib
.
IMAP4
()
self
.
assertIn
(
cm
.
exception
.
errno
,
expected_errnos
)
if
ssl
:
class
SecureTCPServer
(
socketserver
.
TCPServer
):
...
...
Misc/NEWS.d/next/Library/2018-08-02-21-28-38.bpo-18540.AryoYY.rst
0 → 100644
View file @
e4dcbbd7
The :class:`imaplib.IMAP4` and :class:`imaplib.IMAP4_SSL` classes now
resolve to the local host IP correctly when the default value of *host*
parameter (``''``) is used.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment