Issue #19424: PyUnicode_CompareWithASCIIString() normalizes memcmp() result

to -1, 0, 1

Issue #19424: PyUnicode_CompareWithASCIIString() normalizes memcmp() result
to -1, 0, 1
e62099c2 · Victor Stinner · e7319cb0 · e62099c2
Commit e62099c2 authored Nov 04, 2013 by Victor Stinner
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

Objects/unicodeobject.c Objects/unicodeobject.c +6 -2

No files found.
--- a/Objects/unicodeobject.c
+++ b/Objects/unicodeobject.c
@@ -10584,8 +10584,12 @@ PyUnicode_CompareWithASCIIString(PyObject* uni, const char* str)

        len = Py_MIN(len1, len2);
        cmp = memcmp(data, str, len);
-        if (cmp != 0)
-            return cmp;
+        if (cmp != 0) {
+            if (cmp < 0)
+                return -1;
+            else
+                return 1;
+        }
        if (len1 > len2)
            return 1; /* uni is longer */
        if (len2 > len1)