Comparison of two class instances without __cmp__ or __rcmp__ methods

was broken.

Comparison of two class instances without cmp or rcmp methods
was broken.
eb0d181b · Sjoerd Mullender · 24394a78 · eb0d181b
Commit eb0d181b authored Oct 19, 1994 by Sjoerd Mullender
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

Objects/classobject.c Objects/classobject.c +5 -2

No files found.
--- a/Objects/classobject.c
+++ b/Objects/classobject.c
@@ -523,8 +523,11 @@ instance_compare(inst, other)
 	object *result;
 	int outcome;
 	result  = instancebinop(inst, other, "__cmp__", "__rcmp__");
-	if (result == NULL)
+	if (result == NULL) {
-		return -2;
+		/* no __cmp__ or __rcmp__ methods, so use addresses */
+		err_clear();
+		return inst < other ? -1 : (inst > other ? 1 : 0);
+	}
 	outcome = getintvalue(result);
 	DECREF(result);
 	if (outcome == -1 && err_occurred())