Commit ebc793d6 authored by Zackery Spytz's avatar Zackery Spytz Committed by Serhiy Storchaka

bpo-33989: Ensure that ms.key_compare is always initialized in list_sort_impl(). (GH-8710)

parent ef1b88bf
Fix a possible crash in :meth:`list.sort` when sorting objects with
``ob_type->tp_richcompare == NULL``. Patch by Zackery Spytz.
......@@ -2334,6 +2334,9 @@ list_sort_impl(PyListObject *self, PyObject *keyfunc, int reverse)
else if ((ms.key_richcompare = key_type->tp_richcompare) != NULL) {
ms.key_compare = unsafe_object_compare;
}
else {
ms.key_compare = safe_object_compare;
}
}
else {
ms.key_compare = safe_object_compare;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment