Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Open sidebar
Kirill Smelkov
cpython
Commits
ed30199e
Commit
ed30199e
authored
12 years ago
by
Senthil Kumaran
Browse files
Options
Download
Email Patches
Plain Diff
Fix issue16713 - tel url parsing with params
parent
08bab072
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
33 additions
and
1 deletion
+33
-1
Lib/test/test_urlparse.py
Lib/test/test_urlparse.py
+29
-0
Lib/urllib/parse.py
Lib/urllib/parse.py
+1
-1
Misc/NEWS
Misc/NEWS
+3
-0
No files found.
Lib/test/test_urlparse.py
View file @
ed30199e
...
...
@@ -818,6 +818,35 @@ class UrlParseTestCase(unittest.TestCase):
p2
=
urllib
.
parse
.
urlsplit
(
'tel:+31641044153'
)
self
.
assertEqual
(
p2
.
scheme
,
'tel'
)
self
.
assertEqual
(
p2
.
path
,
'+31641044153'
)
# assert the behavior for urlparse
p1
=
urllib
.
parse
.
urlparse
(
'tel:+31-641044153'
)
self
.
assertEqual
(
p1
.
scheme
,
'tel'
)
self
.
assertEqual
(
p1
.
path
,
'+31-641044153'
)
p2
=
urllib
.
parse
.
urlparse
(
'tel:+31641044153'
)
self
.
assertEqual
(
p2
.
scheme
,
'tel'
)
self
.
assertEqual
(
p2
.
path
,
'+31641044153'
)
def
test_telurl_params
(
self
):
p1
=
urllib
.
parse
.
urlparse
(
'tel:123-4;phone-context=+1-650-516'
)
self
.
assertEqual
(
p1
.
scheme
,
'tel'
)
self
.
assertEqual
(
p1
.
path
,
'123-4'
)
self
.
assertEqual
(
p1
.
params
,
'phone-context=+1-650-516'
)
p1
=
urllib
.
parse
.
urlparse
(
'tel:+1-201-555-0123'
)
self
.
assertEqual
(
p1
.
scheme
,
'tel'
)
self
.
assertEqual
(
p1
.
path
,
'+1-201-555-0123'
)
self
.
assertEqual
(
p1
.
params
,
''
)
p1
=
urllib
.
parse
.
urlparse
(
'tel:7042;phone-context=example.com'
)
self
.
assertEqual
(
p1
.
scheme
,
'tel'
)
self
.
assertEqual
(
p1
.
path
,
'7042'
)
self
.
assertEqual
(
p1
.
params
,
'phone-context=example.com'
)
p1
=
urllib
.
parse
.
urlparse
(
'tel:863-1234;phone-context=+1-914-555'
)
self
.
assertEqual
(
p1
.
scheme
,
'tel'
)
self
.
assertEqual
(
p1
.
path
,
'863-1234'
)
self
.
assertEqual
(
p1
.
params
,
'phone-context=+1-914-555'
)
def
test_main
():
support
.
run_unittest
(
UrlParseTestCase
)
...
...
This diff is collapsed.
Click to expand it.
Lib/urllib/parse.py
View file @
ed30199e
...
...
@@ -46,7 +46,7 @@ uses_netloc = ['ftp', 'http', 'gopher', 'nntp', 'telnet',
'svn'
,
'svn+ssh'
,
'sftp'
,
'nfs'
,
'git'
,
'git+ssh'
]
uses_params
=
[
'ftp'
,
'hdl'
,
'prospero'
,
'http'
,
'imap'
,
'https'
,
'shttp'
,
'rtsp'
,
'rtspu'
,
'sip'
,
'sips'
,
'mms'
,
''
,
'sftp'
]
'mms'
,
''
,
'sftp'
,
'tel'
]
# These are not actually used anymore, but should stay for backwards
# compatibility. (They are undocumented, but have a public-looking name.)
...
...
This diff is collapsed.
Click to expand it.
Misc/NEWS
View file @
ed30199e
...
...
@@ -182,6 +182,9 @@ Library
- Issue #16511: Use default IDLE width and height if config param is not valid.
Patch Serhiy Storchaka.
- Issue #16713: Parsing of 'tel' urls using urlparse separates params from
path.
- Issue #16443: Add docstrings to regular expression match objects.
Patch by Anton Kasyanov.
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment