Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
f263724e
Commit
f263724e
authored
Nov 09, 2009
by
Mark Dickinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #7070: Fix problem with builtin round function for large odd
integer arguments. Also fixes the sign of round(-0.0).
parent
c747d3a5
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
20 additions
and
5 deletions
+20
-5
Lib/test/test_builtin.py
Lib/test/test_builtin.py
+9
-0
Misc/NEWS
Misc/NEWS
+2
-0
Python/bltinmodule.c
Python/bltinmodule.c
+9
-5
No files found.
Lib/test/test_builtin.py
View file @
f263724e
# Python test set -- built-in functions
import
platform
import
test.test_support
,
unittest
from
test.test_support
import
fcmp
,
have_unicode
,
TESTFN
,
unlink
,
\
run_unittest
,
run_with_locale
...
...
@@ -1259,6 +1260,14 @@ class BuiltinTest(unittest.TestCase):
self
.
assertRaises
(
TypeError
,
round
,
t
)
self
.
assertRaises
(
TypeError
,
round
,
t
,
0
)
def
test_round_large
(
self
):
# Issue #1869: integral floats should remain unchanged
self
.
assertEqual
(
round
(
5e15
-
1
),
5e15
-
1
)
self
.
assertEqual
(
round
(
5e15
),
5e15
)
self
.
assertEqual
(
round
(
5e15
+
1
),
5e15
+
1
)
self
.
assertEqual
(
round
(
5e15
+
2
),
5e15
+
2
)
self
.
assertEqual
(
round
(
5e15
+
3
),
5e15
+
3
)
def
test_setattr
(
self
):
setattr
(
sys
,
'spam'
,
1
)
self
.
assertEqual
(
sys
.
spam
,
1
)
...
...
Misc/NEWS
View file @
f263724e
...
...
@@ -12,6 +12,8 @@ What's New in Python 2.6.5
Core and Builtins
-----------------
- Issue #7070: Fix round bug for large odd integer arguments.
- Issue #7078: Set struct.__doc__ from _struct.__doc__.
- Issue #1722344: threading._shutdown() is now called in Py_Finalize(), which
...
...
Python/bltinmodule.c
View file @
f263724e
...
...
@@ -2120,7 +2120,7 @@ For most object types, eval(repr(object)) == object.");
static
PyObject
*
builtin_round
(
PyObject
*
self
,
PyObject
*
args
,
PyObject
*
kwds
)
{
double
number
;
double
number
,
abs_number
,
abs_result
;
double
f
;
int
ndigits
=
0
;
int
i
;
...
...
@@ -2137,10 +2137,14 @@ builtin_round(PyObject *self, PyObject *args, PyObject *kwds)
number
/=
f
;
else
number
*=
f
;
if
(
number
>=
0
.
0
)
number
=
floor
(
number
+
0
.
5
);
else
number
=
ceil
(
number
-
0
.
5
);
/* round `number` to nearest integer, rounding halves away from zero */
abs_number
=
fabs
(
number
);
abs_result
=
floor
(
abs_number
);
if
(
abs_number
-
abs_result
>=
0
.
5
)
abs_result
+=
1
.
0
;
number
=
copysign
(
abs_result
,
number
);
if
(
ndigits
<
0
)
number
*=
f
;
else
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment