Commit f2918881 authored by Victor Stinner's avatar Victor Stinner Committed by GitHub

bpo-33901: Fix test_gdbm for gdbm 1.15 (GH-7798) (GH-7818)

Fix test_gdbm.test_reorganize() on macOS with gdbm 1.15: add a
larger value to make sure that the file size changes.

(cherry picked from commit 13c79c677f9ec9437c82eda72fa1c2d288d8fceb)
parent b2dd5f1b
......@@ -62,9 +62,13 @@ class TestGdbm(unittest.TestCase):
self.g = gdbm.open(filename, 'c')
size0 = os.path.getsize(filename)
self.g['x'] = 'x' * 10000
# bpo-33901: on macOS with gdbm 1.15, an empty database uses 16 MiB
# and adding an entry of 10,000 B has no effect on the file size.
# Add size0 bytes to make sure that the file size changes.
value_size = max(size0, 10000)
self.g['x'] = 'x' * value_size
size1 = os.path.getsize(filename)
self.assertTrue(size0 < size1)
self.assertGreater(size1, size0)
del self.g['x']
# 'size' is supposed to be the same even after deleting an entry.
......@@ -72,7 +76,8 @@ class TestGdbm(unittest.TestCase):
self.g.reorganize()
size2 = os.path.getsize(filename)
self.assertTrue(size1 > size2 >= size0)
self.assertLess(size2, size1)
self.assertGreaterEqual(size2, size0)
def test_main():
......
Fix test_gdbm on macOS with gdbm 1.15: add a larger value to make sure that
the file size changes.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment