Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
f344d288
Commit
f344d288
authored
Aug 31, 2013
by
Raymond Hettinger
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Further reduce the cost of hash collisions by inspecting an additional nearby entry.
parent
9accf998
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
39 additions
and
4 deletions
+39
-4
Objects/setobject.c
Objects/setobject.c
+39
-4
No files found.
Objects/setobject.c
View file @
f344d288
...
...
@@ -65,10 +65,11 @@ chaining would be substantial (100% with typical malloc overhead).
The initial probe index is computed as hash mod the table size. Subsequent
probe indices are computed as explained in Objects/dictobject.c.
To improve cache locality, each probe is done in pairs.
After the probe is examined, an adjacent entry is then examined as well.
The likelihood is that an adjacent entry is in the same cache line and
can be examined more cheaply than another probe elsewhere in memory.
To improve cache locality, each probe inspects nearby entries before
moving on to probes elsewhere in memory. Depending on alignment and the
size of a cache line, the nearby entries are cheaper to inspect than
other probes elsewhere in memory. This probe strategy reduces the cost
of hash collisions.
All arithmetic on hash should ignore overflow.
...
...
@@ -130,6 +131,26 @@ set_lookkey(PySetObject *so, PyObject *key, Py_hash_t hash)
if
(
entry
->
key
==
dummy
&&
freeslot
==
NULL
)
freeslot
=
entry
;
entry
=
&
table
[
j
^
2
];
if
(
entry
->
key
==
NULL
)
break
;
if
(
entry
->
key
==
key
)
return
entry
;
if
(
entry
->
hash
==
hash
&&
entry
->
key
!=
dummy
)
{
PyObject
*
startkey
=
entry
->
key
;
Py_INCREF
(
startkey
);
cmp
=
PyObject_RichCompareBool
(
startkey
,
key
,
Py_EQ
);
Py_DECREF
(
startkey
);
if
(
cmp
<
0
)
return
NULL
;
if
(
table
!=
so
->
table
||
entry
->
key
!=
startkey
)
return
set_lookkey
(
so
,
key
,
hash
);
if
(
cmp
>
0
)
return
entry
;
}
if
(
entry
->
key
==
dummy
&&
freeslot
==
NULL
)
freeslot
=
entry
;
i
=
i
*
5
+
perturb
+
1
;
j
=
i
&
mask
;
perturb
>>=
PERTURB_SHIFT
;
...
...
@@ -190,6 +211,17 @@ set_lookkey_unicode(PySetObject *so, PyObject *key, Py_hash_t hash)
if
(
entry
->
key
==
dummy
&&
freeslot
==
NULL
)
freeslot
=
entry
;
entry
=
&
table
[
j
^
2
];
if
(
entry
->
key
==
NULL
)
break
;
if
(
entry
->
key
==
key
||
(
entry
->
hash
==
hash
&&
entry
->
key
!=
dummy
&&
unicode_eq
(
entry
->
key
,
key
)))
return
entry
;
if
(
entry
->
key
==
dummy
&&
freeslot
==
NULL
)
freeslot
=
entry
;
i
=
i
*
5
+
perturb
+
1
;
j
=
i
&
mask
;
perturb
>>=
PERTURB_SHIFT
;
...
...
@@ -256,6 +288,9 @@ set_insert_clean(PySetObject *so, PyObject *key, Py_hash_t hash)
if
(
entry
->
key
==
NULL
)
break
;
entry
=
&
table
[
j
^
1
];
if
(
entry
->
key
==
NULL
)
break
;
entry
=
&
table
[
j
^
2
];
if
(
entry
->
key
==
NULL
)
break
;
i
=
i
*
5
+
perturb
+
1
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment