Commit f3cb68f2 authored by Raymond Hettinger's avatar Raymond Hettinger Committed by GitHub

bpo-37863: Optimize Fraction.__hash__() (#15298)

parent 69f37bcb
...@@ -556,23 +556,19 @@ class Fraction(numbers.Rational): ...@@ -556,23 +556,19 @@ class Fraction(numbers.Rational):
def __hash__(self): def __hash__(self):
"""hash(self)""" """hash(self)"""
# XXX since this method is expensive, consider caching the result # To make sure that the hash of a Fraction agrees with the hash
# of a numerically equal integer, float or Decimal instance, we
# In order to make sure that the hash of a Fraction agrees # follow the rules for numeric hashes outlined in the
# with the hash of a numerically equal integer, float or # documentation. (See library docs, 'Built-in Types').
# Decimal instance, we follow the rules for numeric hashes
# outlined in the documentation. (See library docs, 'Built-in try:
# Types'). dinv = pow(self._denominator, -1, _PyHASH_MODULUS)
except ValueError:
# dinv is the inverse of self._denominator modulo the prime # ValueError means there is no modular inverse
# _PyHASH_MODULUS, or 0 if self._denominator is divisible by
# _PyHASH_MODULUS.
dinv = pow(self._denominator, _PyHASH_MODULUS - 2, _PyHASH_MODULUS)
if not dinv:
hash_ = _PyHASH_INF hash_ = _PyHASH_INF
else: else:
hash_ = abs(self._numerator) * dinv % _PyHASH_MODULUS hash_ = hash(abs(self._numerator)) * dinv % _PyHASH_MODULUS
result = hash_ if self >= 0 else -hash_ result = hash_ if self._numerator >= 0 else -hash_
return -2 if result == -1 else result return -2 if result == -1 else result
def __eq__(a, b): def __eq__(a, b):
......
Optimizations for Fraction.__hash__ suggested by Tim Peters.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment