Commit f439a366 authored by Senthil Kumaran's avatar Senthil Kumaran

Issue #14426: Correct the Date format in Expires attribute of Set-Cookie....

 Issue #14426: Correct the Date format in Expires attribute of Set-Cookie. Patch by Federico Reghenzani and Müte Invert
parent 7961bb30
...@@ -390,7 +390,7 @@ def _getdate(future=0, weekdayname=_weekdayname, monthname=_monthname): ...@@ -390,7 +390,7 @@ def _getdate(future=0, weekdayname=_weekdayname, monthname=_monthname):
from time import gmtime, time from time import gmtime, time
now = time() now = time()
year, month, day, hh, mm, ss, wd, y, z = gmtime(now + future) year, month, day, hh, mm, ss, wd, y, z = gmtime(now + future)
return "%s, %02d-%3s-%4d %02d:%02d:%02d GMT" % \ return "%s, %02d %3s %4d %02d:%02d:%02d GMT" % \
(weekdayname[wd], day, monthname[month], year, hh, mm, ss) (weekdayname[wd], day, monthname[month], year, hh, mm, ss)
......
...@@ -64,13 +64,13 @@ class CookieTests(unittest.TestCase): ...@@ -64,13 +64,13 @@ class CookieTests(unittest.TestCase):
# loading 'expires' # loading 'expires'
C = Cookie.SimpleCookie() C = Cookie.SimpleCookie()
C.load('Customer="W"; expires=Wed, 01-Jan-2010 00:00:00 GMT') C.load('Customer="W"; expires=Wed, 01 Jan 2010 00:00:00 GMT')
self.assertEqual(C['Customer']['expires'], self.assertEqual(C['Customer']['expires'],
'Wed, 01-Jan-2010 00:00:00 GMT') 'Wed, 01 Jan 2010 00:00:00 GMT')
C = Cookie.SimpleCookie() C = Cookie.SimpleCookie()
C.load('Customer="W"; expires=Wed, 01-Jan-98 00:00:00 GMT') C.load('Customer="W"; expires=Wed, 01 Jan 98 00:00:00 GMT')
self.assertEqual(C['Customer']['expires'], self.assertEqual(C['Customer']['expires'],
'Wed, 01-Jan-98 00:00:00 GMT') 'Wed, 01 Jan 98 00:00:00 GMT')
def test_extended_encode(self): def test_extended_encode(self):
# Issue 9824: some browsers don't follow the standard; we now # Issue 9824: some browsers don't follow the standard; we now
......
...@@ -64,6 +64,9 @@ Core and Builtins ...@@ -64,6 +64,9 @@ Core and Builtins
Library Library
------- -------
- Issue #14426: Correct the Date format in Expires attribute of Set-Cookie
Header in Cookie.py.
- Issue #14721: Send proper header, Content-length: 0 when the body is an empty - Issue #14721: Send proper header, Content-length: 0 when the body is an empty
string ''. Initial Patch contributed by Arve Knudsen. string ''. Initial Patch contributed by Arve Knudsen.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment