Commit f7f49e72 authored by Neal Norwitz's avatar Neal Norwitz

Revert 47014 until it is more robust

parent fd277e71
...@@ -34,14 +34,7 @@ class ForkWait(unittest.TestCase): ...@@ -34,14 +34,7 @@ class ForkWait(unittest.TestCase):
pass pass
def wait_impl(self, cpid): def wait_impl(self, cpid):
for i in range(10): spid, status = os.waitpid(cpid, 0)
# waitpid() shouldn't hang, but some of the buildbots seem to hang
# in the forking tests. This is an attempt to fix the problem.
spid, status = os.waitpid(cpid, os.WNOHANG)
if spid == cpid:
break
time.sleep(2 * SHORTSLEEP)
self.assertEquals(spid, cpid) self.assertEquals(spid, cpid)
self.assertEquals(status, 0, "cause = %d, exit = %d" % (status&0xff, status>>8)) self.assertEquals(status, 0, "cause = %d, exit = %d" % (status&0xff, status>>8))
......
...@@ -2,7 +2,6 @@ ...@@ -2,7 +2,6 @@
""" """
import os import os
import time
from test.fork_wait import ForkWait from test.fork_wait import ForkWait
from test.test_support import TestSkipped, run_unittest from test.test_support import TestSkipped, run_unittest
...@@ -13,14 +12,7 @@ except AttributeError: ...@@ -13,14 +12,7 @@ except AttributeError:
class ForkTest(ForkWait): class ForkTest(ForkWait):
def wait_impl(self, cpid): def wait_impl(self, cpid):
for i in range(10): spid, status = os.waitpid(cpid, 0)
# waitpid() shouldn't hang, but some of the buildbots seem to hang
# in the forking tests. This is an attempt to fix the problem.
spid, status = os.waitpid(cpid, os.WNOHANG)
if spid == cpid:
break
time.sleep(1.0)
self.assertEqual(spid, cpid) self.assertEqual(spid, cpid)
self.assertEqual(status, 0, "cause = %d, exit = %d" % (status&0xff, status>>8)) self.assertEqual(status, 0, "cause = %d, exit = %d" % (status&0xff, status>>8))
......
...@@ -2,7 +2,6 @@ ...@@ -2,7 +2,6 @@
""" """
import os import os
import time
from test.fork_wait import ForkWait from test.fork_wait import ForkWait
from test.test_support import TestSkipped, run_unittest from test.test_support import TestSkipped, run_unittest
...@@ -18,14 +17,10 @@ except AttributeError: ...@@ -18,14 +17,10 @@ except AttributeError:
class Wait3Test(ForkWait): class Wait3Test(ForkWait):
def wait_impl(self, cpid): def wait_impl(self, cpid):
for i in range(10): while 1:
# wait3() shouldn't hang, but some of the buildbots seem to hang spid, status, rusage = os.wait3(0)
# in the forking tests. This is an attempt to fix the problem.
spid, status, rusage = os.wait3(os.WNOHANG)
if spid == cpid: if spid == cpid:
break break
time.sleep(1.0)
self.assertEqual(spid, cpid) self.assertEqual(spid, cpid)
self.assertEqual(status, 0, "cause = %d, exit = %d" % (status&0xff, status>>8)) self.assertEqual(status, 0, "cause = %d, exit = %d" % (status&0xff, status>>8))
self.assertTrue(rusage) self.assertTrue(rusage)
......
...@@ -2,7 +2,6 @@ ...@@ -2,7 +2,6 @@
""" """
import os import os
import time
from test.fork_wait import ForkWait from test.fork_wait import ForkWait
from test.test_support import TestSkipped, run_unittest from test.test_support import TestSkipped, run_unittest
...@@ -18,13 +17,7 @@ except AttributeError: ...@@ -18,13 +17,7 @@ except AttributeError:
class Wait4Test(ForkWait): class Wait4Test(ForkWait):
def wait_impl(self, cpid): def wait_impl(self, cpid):
for i in range(10): spid, status, rusage = os.wait4(cpid, 0)
# wait4() shouldn't hang, but some of the buildbots seem to hang
# in the forking tests. This is an attempt to fix the problem.
spid, status, rusage = os.wait4(cpid, os.WNOHANG)
if spid == cpid:
break
time.sleep(1.0)
self.assertEqual(spid, cpid) self.assertEqual(spid, cpid)
self.assertEqual(status, 0, "cause = %d, exit = %d" % (status&0xff, status>>8)) self.assertEqual(status, 0, "cause = %d, exit = %d" % (status&0xff, status>>8))
self.assertTrue(rusage) self.assertTrue(rusage)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment