Commit fa77e09d authored by Barry Warsaw's avatar Barry Warsaw

builtin_map(): A better fix for the previous leak plug (remember

PyList_Append steals a reference even if it fails).

builtin_filter(): Had the same leak problem as builtin_map().
parent c9bda41a
......@@ -232,8 +232,10 @@ builtin_filter(self, args)
goto Fail_1;
}
else {
int status = PyList_Append(result, item);
j++;
if (PyList_Append(result, item) < 0)
Py_DECREF(item);
if (status < 0)
goto Fail_1;
}
} else {
......@@ -901,9 +903,10 @@ builtin_map(self, args)
goto Fail_1;
}
if (i >= len) {
if (PyList_Append(result, value) < 0)
goto Fail_1;
int status = PyList_Append(result, value);
Py_DECREF(value);
if (status < 0)
goto Fail_1;
}
else {
if (PyList_SetItem(result, i, value) < 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment