Commit faf0cd21 authored by Tim Peters's avatar Tim Peters

float_abs() again: Guido pointed out that this could screw up in the

presence of NaNs.  So pass the issue on to the platform libm fabs();
after all, fabs() is a std C function because you can't implement it
correctly in portable C89.
parent 3133f419
......@@ -568,12 +568,7 @@ float_pos(PyFloatObject *v)
static PyObject *
float_abs(PyFloatObject *v)
{
if (v->ob_fval < 0)
return float_neg(v);
else if (v->ob_fval > 0)
return float_pos(v);
else /* ensure abs(-0) is +0 */
return PyFloat_FromDouble(+0.0);
return PyFloat_FromDouble(fabs(v->ob_fval));
}
static int
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment