Commit fb9653a6 authored by Andrew M. Kuchling's avatar Andrew M. Kuchling

Don't use 'file' as a variable name

Modernize the code a bit
Add docstring
parent 87ddce1b
#! /usr/bin/env python #! /usr/bin/env python
# print md5 checksum for files """Python utility to print MD5 checksums of argument files.
"""
bufsize = 8096 bufsize = 8096
fnfilter = None fnfilter = None
...@@ -17,22 +19,19 @@ file ... : files to sum; '-' or no files means stdin ...@@ -17,22 +19,19 @@ file ... : files to sum; '-' or no files means stdin
import sys import sys
import os import os
import getopt
import md5 import md5
import regsub
StringType = type('')
FileType = type(sys.stdin)
def sum(*files): def sum(*files):
sts = 0 sts = 0
if files and type(files[-1]) == FileType: if files and isinstance(files[-1], file):
out, files = files[-1], files[:-1] out, files = files[-1], files[:-1]
else: else:
out = sys.stdout out = sys.stdout
if len(files) == 1 and type(files[0]) != StringType: if len(files) == 1 and not isinstance(files[0], str):
files = files[0] files = files[0]
for f in files: for f in files:
if type(f) == StringType: if isinstance(f, str):
if f == '-': if f == '-':
sts = printsumfp(sys.stdin, '<stdin>', out) or sts sts = printsumfp(sys.stdin, '<stdin>', out) or sts
else: else:
...@@ -41,19 +40,19 @@ def sum(*files): ...@@ -41,19 +40,19 @@ def sum(*files):
sts = sum(f, out) or sts sts = sum(f, out) or sts
return sts return sts
def printsum(file, out = sys.stdout): def printsum(filename, out = sys.stdout):
try: try:
fp = open(file, rmode) fp = open(filename, rmode)
except IOError, msg: except IOError, msg:
sys.stderr.write('%s: Can\'t open: %s\n' % (file, msg)) sys.stderr.write('%s: Can\'t open: %s\n' % (filename, msg))
return 1 return 1
if fnfilter: if fnfilter:
file = fnfilter(file) filename = fnfilter(filename)
sts = printsumfp(fp, file, out) sts = printsumfp(fp, filename, out)
fp.close() fp.close()
return sts return sts
def printsumfp(fp, file, out = sys.stdout): def printsumfp(fp, filename, out = sys.stdout):
m = md5.new() m = md5.new()
try: try:
while 1: while 1:
...@@ -61,20 +60,13 @@ def printsumfp(fp, file, out = sys.stdout): ...@@ -61,20 +60,13 @@ def printsumfp(fp, file, out = sys.stdout):
if not data: break if not data: break
m.update(data) m.update(data)
except IOError, msg: except IOError, msg:
sys.stderr.write('%s: I/O error: %s\n' % (file, msg)) sys.stderr.write('%s: I/O error: %s\n' % (filename, msg))
return 1 return 1
out.write('%s %s\n' % (hexify(m.digest()), file)) out.write('%s %s\n' % (m.hexdigest(), filename))
return 0 return 0
def hexify(s):
res = ''
for c in s:
res = res + '%02x' % ord(c)
return res
def main(args = sys.argv[1:], out = sys.stdout): def main(args = sys.argv[1:], out = sys.stdout):
global fnfilter, rmode, bufsize global fnfilter, rmode, bufsize
import getopt
try: try:
opts, args = getopt.getopt(args, 'blts:') opts, args = getopt.getopt(args, 'blts:')
except getopt.error, msg: except getopt.error, msg:
...@@ -89,7 +81,8 @@ def main(args = sys.argv[1:], out = sys.stdout): ...@@ -89,7 +81,8 @@ def main(args = sys.argv[1:], out = sys.stdout):
rmode = 'r' rmode = 'r'
if o == '-s': if o == '-s':
bufsize = int(a) bufsize = int(a)
if not args: args = ['-'] if not args:
args = ['-']
return sum(args, out) return sum(args, out)
if __name__ == '__main__' or __name__ == sys.argv[0]: if __name__ == '__main__' or __name__ == sys.argv[0]:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment