Commit fedd4815 authored by Antoine Pitrou's avatar Antoine Pitrou

Try to make signal-sending tests in test_subprocess more robust on slow machines

parent fb8db8f6
...@@ -830,16 +830,18 @@ class POSIXProcessTestCase(BaseTestCase): ...@@ -830,16 +830,18 @@ class POSIXProcessTestCase(BaseTestCase):
stdin=subprocess.PIPE, stderr=subprocess.PIPE) stdin=subprocess.PIPE, stderr=subprocess.PIPE)
# Let the process initialize (Issue #3137) # Let the process initialize (Issue #3137)
time.sleep(0.1) time.sleep(0.4)
# The process should not terminate prematurely # The process should not terminate prematurely
self.assertIsNone(p.poll()) self.assertIsNone(p.poll())
# Retry if the process do not receive the signal. # Retry if the process do not receive the signal.
count, maxcount = 0, 3 count, maxcount = 0, 10
while count < maxcount and p.poll() is None: while count < maxcount and p.poll() is None:
getattr(p, method)(*args) getattr(p, method)(*args)
time.sleep(0.1) time.sleep(0.1)
count += 1 count += 1
if count == maxcount:
self.skipTest("apparently failed to send the signal")
self.assertIsNotNone(p.poll(), "the subprocess did not terminate") self.assertIsNotNone(p.poll(), "the subprocess did not terminate")
if count > 1: if count > 1:
print("p.{}{} succeeded after " print("p.{}{} succeeded after "
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment