Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
ff7a922e
Commit
ff7a922e
authored
Nov 05, 2011
by
Petri Lehtinen
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Accept None as start and stop parameters for list.index() and tuple.index()
Closes #13340.
parent
c1c709d0
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
39 additions
and
7 deletions
+39
-7
Lib/test/list_tests.py
Lib/test/list_tests.py
+7
-0
Lib/test/seq_tests.py
Lib/test/seq_tests.py
+7
-0
Misc/NEWS
Misc/NEWS
+3
-0
Objects/listobject.c
Objects/listobject.c
+11
-3
Objects/tupleobject.c
Objects/tupleobject.c
+11
-4
No files found.
Lib/test/list_tests.py
View file @
ff7a922e
...
...
@@ -365,6 +365,13 @@ class CommonTest(seq_tests.CommonTest):
self
.
assertEqual
(
u
.
index
(
0
,
3
),
3
)
self
.
assertEqual
(
u
.
index
(
0
,
3
,
4
),
3
)
self
.
assertRaises
(
ValueError
,
u
.
index
,
2
,
0
,
-
10
)
self
.
assertEqual
(
u
.
index
(
1
,
None
),
4
)
self
.
assertEqual
(
u
.
index
(
1
,
None
,
None
),
4
)
self
.
assertEqual
(
u
.
index
(
1
,
0
,
None
),
4
)
self
.
assertEqual
(
u
.
index
(
1
,
None
,
6
),
4
)
self
.
assertRaises
(
ValueError
,
u
.
index
,
-
1
,
3
)
self
.
assertRaises
(
ValueError
,
u
.
index
,
-
1
,
3
,
None
)
self
.
assertRaises
(
ValueError
,
u
.
index
,
1
,
None
,
4
)
self
.
assertRaises
(
TypeError
,
u
.
index
)
...
...
Lib/test/seq_tests.py
View file @
ff7a922e
...
...
@@ -363,6 +363,13 @@ class CommonTest(unittest.TestCase):
self
.
assertEqual
(
u
.
index
(
0
,
3
),
3
)
self
.
assertEqual
(
u
.
index
(
0
,
3
,
4
),
3
)
self
.
assertRaises
(
ValueError
,
u
.
index
,
2
,
0
,
-
10
)
self
.
assertEqual
(
u
.
index
(
1
,
None
),
4
)
self
.
assertEqual
(
u
.
index
(
1
,
None
,
None
),
4
)
self
.
assertEqual
(
u
.
index
(
1
,
0
,
None
),
4
)
self
.
assertEqual
(
u
.
index
(
1
,
None
,
6
),
4
)
self
.
assertRaises
(
ValueError
,
u
.
index
,
-
1
,
3
)
self
.
assertRaises
(
ValueError
,
u
.
index
,
-
1
,
3
,
None
)
self
.
assertRaises
(
ValueError
,
u
.
index
,
1
,
None
,
4
)
self
.
assertRaises
(
TypeError
,
u
.
index
)
...
...
Misc/NEWS
View file @
ff7a922e
...
...
@@ -9,6 +9,9 @@ What's New in Python 2.7.3?
Core and Builtins
-----------------
- Issue #13340: Accept None as start and stop parameters for
list.index() and tuple.index().
- Issue #10519: Avoid unnecessary recursive function calls in
setobject.c.
...
...
Objects/listobject.c
View file @
ff7a922e
...
...
@@ -2277,12 +2277,20 @@ listindex(PyListObject *self, PyObject *args)
{
Py_ssize_t
i
,
start
=
0
,
stop
=
Py_SIZE
(
self
);
PyObject
*
v
,
*
format_tuple
,
*
err_string
;
PyObject
*
start_obj
=
NULL
,
*
stop_obj
=
NULL
;
static
PyObject
*
err_format
=
NULL
;
if
(
!
PyArg_ParseTuple
(
args
,
"O|O&O&:index"
,
&
v
,
_PyEval_SliceIndex
,
&
start
,
_PyEval_SliceIndex
,
&
stop
))
if
(
!
PyArg_ParseTuple
(
args
,
"O|OO:index"
,
&
v
,
&
start_obj
,
&
stop_obj
))
return
NULL
;
if
(
start_obj
!=
Py_None
)
if
(
!
_PyEval_SliceIndex
(
start_obj
,
&
start
))
return
NULL
;
if
(
stop_obj
!=
Py_None
)
if
(
!
_PyEval_SliceIndex
(
stop_obj
,
&
stop
))
return
NULL
;
if
(
start
<
0
)
{
start
+=
Py_SIZE
(
self
);
if
(
start
<
0
)
...
...
Objects/tupleobject.c
View file @
ff7a922e
...
...
@@ -510,12 +510,19 @@ static PyObject *
tupleindex
(
PyTupleObject
*
self
,
PyObject
*
args
)
{
Py_ssize_t
i
,
start
=
0
,
stop
=
Py_SIZE
(
self
);
PyObject
*
v
;
PyObject
*
v
,
*
start_obj
=
NULL
,
*
stop_obj
=
NULL
;
if
(
!
PyArg_ParseTuple
(
args
,
"O|O&O&:index"
,
&
v
,
_PyEval_SliceIndex
,
&
start
,
_PyEval_SliceIndex
,
&
stop
))
if
(
!
PyArg_ParseTuple
(
args
,
"O|OO:index"
,
&
v
,
&
start_obj
,
&
stop_obj
))
return
NULL
;
if
(
start_obj
!=
Py_None
)
if
(
!
_PyEval_SliceIndex
(
start_obj
,
&
start
))
return
NULL
;
if
(
stop_obj
!=
Py_None
)
if
(
!
_PyEval_SliceIndex
(
stop_obj
,
&
stop
))
return
NULL
;
if
(
start
<
0
)
{
start
+=
Py_SIZE
(
self
);
if
(
start
<
0
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment