1. 18 Jul, 2019 1 commit
  2. 17 Jul, 2019 7 commits
  3. 16 Jul, 2019 5 commits
  4. 15 Jul, 2019 3 commits
  5. 14 Jul, 2019 10 commits
  6. 13 Jul, 2019 10 commits
  7. 12 Jul, 2019 3 commits
  8. 11 Jul, 2019 1 commit
    • Disconnect3d's avatar
      Remove redundant check from arraymodule b_getitem (GH-14676) · 13ab570f
      Disconnect3d authored
      
      
      The `arraymodule`'s `b_getitem` function returns a `PyLong` converted 
      from `arrayobject`'s array, by dereferencing a pointer to `char`.
      
      When the `char` type is `signed char`, the `if (x >= 128) x -= 256;` comparison/code is redundant because a `signed char` will have a value of `[-128, 127]` and so `x` will never be greater or equal than 128.
      
      This check was indeed needed for situations where a given compiler would assume `char` being `unsigned char` which would make `x` in `[0, 256]` range.
      
      However, the check can be removed if we cast the `ob_item` into a signed char pointer (`signed char*`) instead of `char*`.
      
      This PR/commit introduces this change.
      13ab570f