Skip to content

C
cpython
Switch branch/tag
  1. 11 Dec, 2012 4 commits
    • Gregory P. Smith's avatar
      Using 'long double' to force this structure to be worst case aligned is no · 1eef021c
      Gregory P. Smith authored 
      longer required as of Python 2.5+ when the gc_refs changed from an int (4
bytes) to a Py_ssize_t (8 bytes) as the minimum size is 16 bytes.

The use of a 'long double' triggered a warning by Clang trunk's
Undefined-Behavior Sanitizer as on many platforms a long double requires
16-byte alignment but the Python memory allocator only guarantees 8 byte
alignment.

So our code would allocate and use these structures with technically improper
alignment.  Though it didn't matter since the 'dummy' field is never used.
This silences that warning.

Spelunking into code history, the double was added in 2001 to force better
alignment on some platforms and changed to a long double in 2002 to appease
Tru64.  That issue should no loner be present since the upgrade from int to
Py_ssize_t where the minimum structure size increased to 16 (unless anyone
knows of a platform where ssize_t is 4 bytes?) or 24 bytes depending on if the
build uses 4 or 8 byte pointers.

We can probably get rid of the double and this union hack all together today.
That is a slightly more invasive change that can be left for later.

A more correct non-hacky alternative if any alignment issues are still found
would be to use a compiler specific alignment declaration on the structure and
determine which value to use at configure time.
      1eef021c
    • Gregory P. Smith's avatar
      1 << 31 is invalid for signed integers, fix it by making 1 unsigned. · 023b8e4c
      Gregory P. Smith authored 
      Found by Clang trunk's Undefined-Behavior Sanitizer.  [more to come]
      023b8e4c
    • Gregory P. Smith's avatar
      1 << 31 is invalid for signed integers, fix it by making 1 unsigned. · 09b55fd8
      Gregory P. Smith authored 
      Found by Clang trunk's Undefined-Behavior Sanitizer.  [more to come]
      09b55fd8
    • Gregory P. Smith's avatar
      1 << 31 is invalid for signed integers, fix it by making 1 unsigned. · 0081f3e8
      Gregory P. Smith authored 
      Found by Clang trunk's Undefined-Behavior Sanitizer.  [more to come]
      0081f3e8
  3. 10 Dec, 2012 19 commits
  5. 09 Dec, 2012 17 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7