- 14 Aug, 2006 3 commits
-
-
Neal Norwitz authored
-
Neal Norwitz authored
about the best we can do is call PyErr_WriteUnraisable and go on. We won't be able to do the call below either, so verify delstr is valid.
-
Neal Norwitz authored
-
- 13 Aug, 2006 14 commits
-
-
Neal Norwitz authored
-
Neal Norwitz authored
Klocwork 225-228
-
Neal Norwitz authored
Klocwork 281
-
Neal Norwitz authored
(Followup of Klocwork 274)
-
Neal Norwitz authored
Fix a bunch of refleaks in the init of the module. This would only be found when running python -v.
-
Neal Norwitz authored
Klocwork 341-342
-
Neal Norwitz authored
that PyString_AsString() returns a valid pointer. (The problem can arise when zlib.decompress doesn't return a string.) Klocwork 346
-
Neal Norwitz authored
Klocwork 180-181
-
Neal Norwitz authored
Fix a bunch of refleaks in the init of the module. This would only be found when running python -v.
-
Neal Norwitz authored
__oct__, __hex__ don't return a string. Klocwork 308
-
Neal Norwitz authored
to write the .pyc to NULL. Check results of PyList_GetItem() and PyModule_GetDict() are not NULL. Klocwork 282, 283, 285
-
Neal Norwitz authored
Should fix most of Klocwork 234-272.
-
Neal Norwitz authored
Verify that PyEval_Get{Globals,Locals} returned valid pointers. Klocwork 231-232
-
Neal Norwitz authored
-
- 12 Aug, 2006 20 commits
-
-
Neal Norwitz authored
were failing due to inappropriate clipping of numbers larger than 2**31 with new-style classes. (typeobject.c) In reviewing the code for classic classes, there were 2 problems. Any negative value return could be returned. Always return -1 if there was an error. Also make the checks similar with the new-style classes. I believe this is correct for 32 and 64 bit boxes, including Windows64. Add a test of classic classes too.
-
Neal Norwitz authored
I modified this patch some by fixing style, some error checking, and adding XXX comments. This patch requires review and some changes are to be expected. I'm checking in now to get the greatest possible review and establish a baseline for moving forward. I don't want this to hold up release if possible.
-
Georg Brandl authored
-
Tim Peters authored
protected by "if verbose:", which caused the test to fail on all non-Windows boxes. Note that I deliberately didn't convert this to unittest yet, because I expect it would be even harder to debug this on Tru64 after conversion.
-
Tim Peters authored
appears to be utterly insane. Plug some theoretical insecurities in the test script: - Verify that the SIGALRM handler was actually installed. - Don't call alarm() before the handler is installed. - Move everything that can fail inside the try/finally, so the test cleans up after itself more often. - Try sending all the expected signals in force_test_exit(), not just SIGALRM. Since that was fixed to actually send SIGALRM (instead of invisibly dying with an AttributeError), we've seen that sending SIGALRM alone does not stop this from hanging. - Move the "kill the child" business into the finally clause, so the child doesn't survive test failure to send SIGALRM to other tests later (there are also baffling SIGALRM-related failures in test_socket). - Cancel the alarm in the finally clause -- if the test dies early, we again don't want SIGALRM showing up to confuse a later test. Alas, this still relies on timing luck wrt the spawned script that sends the test signals, but it's hard to see how waiting for seconds can so often be so unlucky. test_threadedsignals: curiously, this test never fails on Tru64, but doesn't normally signal SIGALRM. Anyway, fixed an obvious (but probably inconsequential) logic error.
-
Neal Norwitz authored
Ensure we don't pass NULL to free. Klocwork #306 (at least the first part, checking malloc)
-
Neal Norwitz authored
Klocwork #298-299.
-
Neal Norwitz authored
Check seq in both portions of if/else. Klocwork #289-290.
-
Neal Norwitz authored
Klocwork #214
-
Neal Norwitz authored
Whoops, how did that get in there. :-) Revert all the parts of 51227 that were not supposed to go it. Only Modules/_ctypes/cfields.c was supposed to be changed
-
Neal Norwitz authored
Klocwork #233
-
Neal Norwitz authored
I think it would be better to always use snprintf and have the format limit the size of the name appropriately (like %.200s). Klocwork #340
-
Neal Norwitz authored
There might be something else we need to do to handle the exception. Klocwork # 212-213
-
Neal Norwitz authored
Klocwork #274.
-
Neal Norwitz authored
Return early in that case. The caller checks for PyErr_Occurred so this should be ok. Klocwork #297
-
Neal Norwitz authored
There might be something else that needs to be done to setup the error. Klocwork #295.
-
Neal Norwitz authored
However, there was no error checking that PyFloat_FromDouble returned a valid pointer. I believe this change is correct as it seemed to follow other code in the area. Klocwork # 292.
-
Neal Norwitz authored
So be safe and do an XINCREF. Klocwork # 221-222.
-
Neal Norwitz authored
there was no verification that privateobj was a PyString. If it wasn't a string, this could have allowed a NULL pointer to creep in below and crash. I wonder if this should be PyString_CheckExact? Must identifiers be strings or can they be subclasses? Klocwork #275
-
Neal Norwitz authored
This is the first batch of fixes that should be easy to verify based on context. This fixes problem numbers: 220 (ast), 323-324 (symtable), 321-322 (structseq), 215 (array), 210 (hotshot), 182 (codecs), 209 (etree).
-
- 11 Aug, 2006 3 commits
-
-
Thomas Heller authored
storage before converting the result to C data. See the comment in the code for details. Provide a better context for errors when the conversion of a callback function's result cannot be converted.
-
Thomas Wouters authored
-
Georg Brandl authored
already been cleaned up.
-