1. 11 Dec, 2012 4 commits
    • Gregory P. Smith's avatar
      Fix the internals of our hash functions to used unsigned values during hash · c2176e46
      Gregory P. Smith authored
      computation as the overflow behavior of signed integers is undefined.
      
      NOTE: This change is smaller compared to 3.2 as much of this cleanup had
      already been done.  I added the comment that my change in 3.2 added so that the
      code would match up.  Otherwise this just adds or synchronizes appropriate UL
      designations on some constants to be pedantic.
      
      In practice we require compiling everything with -fwrapv which forces overflow
      to be defined as twos compliment but this keeps the code cleaner for checkers
      or in the case where someone has compiled it without -fwrapv or their
      compiler's equivalent.
      
      Found by Clang trunk's Undefined Behavior Sanitizer (UBSan).
      
      Cleanup only - no functionality or hash values change.
      c2176e46
    • Gregory P. Smith's avatar
      Fix the internals of our hash functions to used unsigned values during hash · 27cbcd62
      Gregory P. Smith authored
      computation as the overflow behavior of signed integers is undefined.
      
      In practice we require compiling everything with -fwrapv which forces overflow
      to be defined as twos compliment but this keeps the code cleaner for checkers
      or in the case where someone has compiled it without -fwrapv or their
      compiler's equivalent.
      
      Found by Clang trunk's Undefined Behavior Sanitizer (UBSan).
      
      Cleanup only - no functionality or hash values change.
      27cbcd62
    • Gregory P. Smith's avatar
      1 << 31 is invalid for signed integers, fix it by making 1 unsigned. · c0dd80e4
      Gregory P. Smith authored
      Found by Clang trunk's Undefined-Behavior Sanitizer.  [more to come]
      c0dd80e4
    • Gregory P. Smith's avatar
      1 << 31 is invalid for signed integers, fix it by making 1 unsigned. · 90555d0f
      Gregory P. Smith authored
      Found by Clang trunk's Undefined-Behavior Sanitizer.  [more to come]
      90555d0f
  2. 10 Dec, 2012 12 commits
  3. 09 Dec, 2012 13 commits
  4. 08 Dec, 2012 11 commits