1. 04 Apr, 2008 5 commits
  2. 03 Apr, 2008 6 commits
    • Trent Nelson's avatar
      Merged revisions 62129,62131,62133 via svnmerge from · e7be2782
      Trent Nelson authored
      svn+ssh://pythondev@svn.python.org/python/trunk
      
      ........
        r62129 | trent.nelson | 2008-04-03 19:27:06 +0100 (Thu, 03 Apr 2008) | 16 lines
      
        Reimplement kill_python.  The existing version had a number of flaws, namely, it didn't work for x64 and it wasn't precise about which python_d.exe it was killing -- it just killed the first one it came across that happened to have 'pcbuild\python_d.exe' or 'build\python_d.exe' in it's path.  The new version has been rewritten from the ground up and now lives in PCbuild, instead of Tools\buildbot, and it has also been incorporated into the Visual Studio solution (pcbuild.sln) as 'kill_python'.  The solution has also been altered such that kill_python is called where necessary in the build process in order to prevent any linking errors due to open file locks.  In lieu of this, all of the existing bits and pieces in Tools\buildbot that called out to kill_python at various points have also been removed as they are now obsolete.  Tested on both Win32 and x64.
      
        Change set (included to improve usefulness of svnmerge log entry):
        M      PCbuild\pythoncore.vcproj
        M      PCbuild\pcbuild.sln
        M      PCbuild\release.vsprops
        A      PCbuild\kill_python.vcproj
        M      PCbuild\debug.vsprops
        A      PCbuild\kill_python.c
        D      Tools\buildbot\kill_python.bat
        D      Tools\buildbot\kill_python.mak
        M      Tools\buildbot\build.bat
        D      Tools\buildbot\Makefile
        M      Tools\buildbot\build-amd64.bat
        M      Tools\buildbot\buildmsi.bat
        D      Tools\buildbot\kill_python.c
      ........
        r62131 | trent.nelson | 2008-04-03 19:48:53 +0100 (Thu, 03 Apr 2008) | 1 line
      
        Add the correct OutputFile values for debug builds.  Fixes r62129's commit.
      ........
        r62133 | trent.nelson | 2008-04-03 21:00:08 +0100 (Thu, 03 Apr 2008) | 1 line
      
        Make kill_python a little more forgiving if it can't obtain a snapshot of module information for a given python[_d].exe process.  Failing here was too pessimistic; the python[_d].exe process may be owned by another user, which is the case in some buildbot environments.
      ........
      e7be2782
    • Trent Nelson's avatar
      Unblock revision 62129. · 4045588b
      Trent Nelson authored
      4045588b
    • Benjamin Peterson's avatar
      Blocked revisions 62123,62126 via svnmerge · 59c9e979
      Benjamin Peterson authored
      ........
        r62123 | barry.warsaw | 2008-04-02 23:10:02 -0500 (Wed, 02 Apr 2008) | 2 lines
      
        Updating for 2.6a2
      ........
        r62126 | barry.warsaw | 2008-04-02 23:14:19 -0500 (Wed, 02 Apr 2008) | 1 line
      
        Post tag version tweak
      ........
      59c9e979
    • Trent Nelson's avatar
      [XXX: this is a temporary block, given the addition/deletion of new files I'll... · b982f8b0
      Trent Nelson authored
      [XXX: this is a temporary block, given the addition/deletion of new files I'll unblock and merge it to py3k myself once I've observed trunk buildbots' behaviour.]
      
      Blocked revisions 62129 via svnmerge
      
      ........
        r62129 | trent.nelson | 2008-04-03 19:27:06 +0100 (Thu, 03 Apr 2008) | 16 lines
      
        Reimplement kill_python.  The existing version had a number of flaws, namely, it didn't work for x64 and it wasn't precise about which python_d.exe it was killing -- it just killed the first one it came across that happened to have 'pcbuild\python_d.exe' or 'build\python_d.exe' in it's path.  The new version has been rewritten from the ground up and now lives in PCbuild, instead of Tools\buildbot, and it has also been incorporated into the Visual Studio solution (pcbuild.sln) as 'kill_python'.  The solution has also been altered such that kill_python is called where necessary in the build process in order to prevent any linking errors due to open file locks.  In lieu of this, all of the existing bits and pieces in Tools\buildbot that called out to kill_python at various points have also been removed as they are now obsolete.  Tested on both Win32 and x64.
      
        Change set (included to improve usefulness of svnmerge log entry):
        M      PCbuild\pythoncore.vcproj
        M      PCbuild\pcbuild.sln
        M      PCbuild\release.vsprops
        A      PCbuild\kill_python.vcproj
        M      PCbuild\debug.vsprops
        A      PCbuild\kill_python.c
        D      Tools\buildbot\kill_python.bat
        D      Tools\buildbot\kill_python.mak
        M      Tools\buildbot\build.bat
        D      Tools\buildbot\Makefile
        M      Tools\buildbot\build-amd64.bat
        M      Tools\buildbot\buildmsi.bat
        D      Tools\buildbot\kill_python.c
      ........
      b982f8b0
    • Benjamin Peterson's avatar
      b7f85160
    • Barry Warsaw's avatar
      Post tag version tweak · 53a32956
      Barry Warsaw authored
      53a32956
  3. 02 Apr, 2008 9 commits
    • Barry Warsaw's avatar
      Tagging 3.0a4. · 99744ad6
      Barry Warsaw authored
      99744ad6
    • Barry Warsaw's avatar
      4a38a7ed
    • Barry Warsaw's avatar
      release.py wants to rename the spec file. · 3fe7e247
      Barry Warsaw authored
      3fe7e247
    • Benjamin Peterson's avatar
      44df4008
    • Benjamin Peterson's avatar
      Merged revisions 62090-62091,62096,62100,62102,62110-62114 via svnmerge from · 4a7d4a13
      Benjamin Peterson authored
      svn+ssh://pythondev@svn.python.org/python/trunk
      
      ........
        r62090 | brett.cannon | 2008-04-01 07:37:43 -0500 (Tue, 01 Apr 2008) | 3 lines
      
        Generalize test.test_support.test_stdout() with a base context manager so that
        it is easy to capture stderr if desired.
      ........
        r62091 | brett.cannon | 2008-04-01 07:46:02 -0500 (Tue, 01 Apr 2008) | 3 lines
      
        Add ``if __name__ == '__main__'`` to some test files where it didn't take a lot
        of effort to do so.
      ........
        r62096 | amaury.forgeotdarc | 2008-04-01 17:52:48 -0500 (Tue, 01 Apr 2008) | 4 lines
      
        Newly enabled test appears to leak:
        it registers the same codec on each iteration.
        Do it only once at load time.
      ........
        r62100 | amaury.forgeotdarc | 2008-04-01 19:55:04 -0500 (Tue, 01 Apr 2008) | 4 lines
      
        A DocTestSuite cannot run multiple times: it clears its globals dictionary after the first run.
      
        Rebuild the DocTestSuite on each iteration.
      ........
        r62102 | jeffrey.yasskin | 2008-04-01 23:07:44 -0500 (Tue, 01 Apr 2008) | 3 lines
      
        Try to make test_signal less flaky.  I still see some flakiness in
        test_itimer_prof.
      ........
        r62110 | vinay.sajip | 2008-04-02 16:09:27 -0500 (Wed, 02 Apr 2008) | 1 line
      
        Fix: #2315, #2316, #2317: TimedRotatingFileHandler - changed logic to better handle daylight savings time, deletion of old log files, and fixed a bug in calculating rollover when no logging occurs for a longer interval than the rollover period.
      ........
        r62111 | vinay.sajip | 2008-04-02 16:10:23 -0500 (Wed, 02 Apr 2008) | 1 line
      
        Added updates with respect to recent changes to TimedRotatingFileHandler.
      ........
        r62112 | vinay.sajip | 2008-04-02 16:17:25 -0500 (Wed, 02 Apr 2008) | 1 line
      
        Added updates with respect to recent changes to TimedRotatingFileHandler.
      ........
        r62113 | amaury.forgeotdarc | 2008-04-02 16:18:46 -0500 (Wed, 02 Apr 2008) | 2 lines
      
        Remove debug prints; the buildbot now passes the tests
      ........
        r62114 | benjamin.peterson | 2008-04-02 16:20:35 -0500 (Wed, 02 Apr 2008) | 2 lines
      
        Suggested proposed changes to Python be considered on some mailing lists first
      ........
      4a7d4a13
    • Benjamin Peterson's avatar
      Blocked revisions 62097 via svnmerge · 44029fb5
      Benjamin Peterson authored
      ........
        r62097 | guido.van.rossum | 2008-04-01 18:57:36 -0500 (Tue, 01 Apr 2008) | 3 lines
      
        Remove the advertising clause from the BSD license in timing.h.
        I have the email trail to prove that George Neville-Neil approved this.
      ........
      44029fb5
    • Trent Nelson's avatar
      Merged revisions 62105 via svnmerge from · 4ec9c1bb
      Trent Nelson authored
      svn+ssh://pythondev@svn.python.org/python/trunk
      
      ........
        r62105 | trent.nelson | 2008-04-02 16:01:00 +0100 (Wed, 02 Apr 2008) | 1 line
      
        Update information pertaining to building external components, as well as notes on x64 builds.  This file now accurately describes the build process as is; however, there's still a lot of room for improvement, especially with regards to how we build Tcl/Tk, Tix, and OpenSSL.  Watch this space for further improvements.
      ........
      4ec9c1bb
    • Neal Norwitz's avatar
      Blocked revisions 62103 via svnmerge · 4800b06b
      Neal Norwitz authored
      ........
        r62103 | neal.norwitz | 2008-04-01 22:54:27 -0700 (Tue, 01 Apr 2008) | 3 lines
      
        Apply same patch from 3k branch to try and prevent this test from hanging
        on various platforms, most recently the Alpha Tru64.
      ........
      4800b06b
    • Benjamin Peterson's avatar
      Blocked revisions 62095,62099 via svnmerge · bb5977df
      Benjamin Peterson authored
      ........
        r62095 | amaury.forgeotdarc | 2008-04-01 17:37:33 -0500 (Tue, 01 Apr 2008) | 5 lines
      
        Fix and enable a skipped test:
        with python 2.6, enumerating bytes yields 1-char strings, not numbers.
      
        Don't merge this into the py3k branch.
      ........
        r62099 | amaury.forgeotdarc | 2008-04-01 19:25:14 -0500 (Tue, 01 Apr 2008) | 14 lines
      
        Correct the apparent refleak in test_io:
        When cls is an ABCMeta, every call to isinstance(x, cls)
        records type(x) in the cls._abc_cache of cls_abc_negative_cache.
        So we clear these caches at the end of the test.
      
        inspect.isabstract() is not the correct test for all ABCs, because there is no @abstractmethod in io.py (why?)
        isinstance(cls, ABCMeta) would be more exact, but it fails with an infinite recursion.
        So I used a hack to determine whether a class is an ABCMeta.
      
        The true correction would be to turn cls._abc_cache &co into a WeakSet, as py3k does.
        But classic classes are not weak referenceable...
      
        Of course, this change should not be merged into the py3k branch.
      ........
      bb5977df
  4. 01 Apr, 2008 5 commits
    • Amaury Forgeot d'Arc's avatar
      Prevent test_queue from leaking: one worker thread was not stopped. · 5f744a1a
      Amaury Forgeot d'Arc authored
      The version in trunk/ is correct; the problem with 3.0 is that
      None cannot be used as a marker in a PriorityQueue, because it cannot be compared with ints.
      5f744a1a
    • Neal Norwitz's avatar
    • Neal Norwitz's avatar
    • Neal Norwitz's avatar
      Fix a refleak · 38a260ad
      Neal Norwitz authored
      38a260ad
    • Martin v. Löwis's avatar
      Merged revisions... · ce43f0b6
      Martin v. Löwis authored
      Merged revisions 61440-61441,61443,61445-61448,61451-61452,61455-61457,61459-61464,61466-61467,61469-61470,61476-61477,61479,61481-61482,61485,61487,61490,61493-61494,61497,61499-61502,61505-61506,61508,61511-61514,61519,61521-61522,61530-61531,61533-61537,61541-61555,61557-61558,61561-61562,61566-61569,61572-61574,61578-61579,61583-61584,61588-61589,61592,61594,61598-61601,61603-61604,61607-61612,61617,61619-61620,61624,61626,61628-61630,61635-61638,61640-61643,61645,61648,61653-61655,61659-61662,61664,61666,61668-61671,61673,61675,61679-61680,61682,61685-61686,61689-61695,61697-61699,61701-61703,61706,61710,61713,61717,61723,61726-61730,61736,61738,61740,61742,61745-61752,61754-61760,61762-61764,61768,61770-61772,61774-61775,61784-61787,61789-61792,61794-61795,61797-61806,61808-61809,61811-61812,61814-61819,61824,61826-61833,61835-61840,61843-61845,61848,61850,61854-61862,61865-61866,61868,61872-61873,61876-61877,61883-61888,61890-61891,61893-61899,61901-61903,61905-61912,61914,61917,61920-61921,61927,61930,61932-61934,61939,61941-61942,61944-61951,61955,61960-61963,61980,61982-61983,61991,61994-61996,62001-62003,62008-62010,62016-62017,62022,62024,62027,62031-62034,62041,62045-62046,62055-62058,62060-62066,62068-62074,62076-62085 via svnmerge from
      svn+ssh://pythondev@svn.python.org/python/trunk
      
      ................
        r62080 | martin.v.loewis | 2008-03-31 07:20:55 +0200 (Mo, 31 Mär 2008) | 9 lines
      
        Merged revisions 61990-62079 via svnmerge from
        svn+ssh://pythondev@svn.python.org/sandbox/trunk/2to3/lib2to3
      
        ........
          r62017 | david.wolever | 2008-03-28 21:54:37 +0100 (Fr, 28 Mär 2008) | 1 line
      
          Fixed an out-of-date comment.
        ........
      ................
        r62084 | benjamin.peterson | 2008-03-31 23:57:13 +0200 (Mo, 31 Mär 2008) | 2 lines
      
        PyErr_Warn is decrepated. Use PyErr_WarnEx
      ................
        r62085 | neal.norwitz | 2008-04-01 07:40:43 +0200 (Di, 01 Apr 2008) | 4 lines
      
        Be sure to close the file.  2 places were deleting the file, so it was probably
        fine, but the last change may be required for the test to pass on Windows.
        Should we always close the mmap too?
      ................
      ce43f0b6
  5. 31 Mar, 2008 12 commits
    • Neal Norwitz's avatar
      This was required on OS X to prevent the test from deadlocking. I'm not sure · 928a180e
      Neal Norwitz authored
      if this is just a test problem or something deeper.  Hopefully the test will
      stop hanging.
      928a180e
    • Neal Norwitz's avatar
      Merged revisions... · 97da44f7
      Neal Norwitz authored
      Merged revisions 61440-61441,61443,61445-61448,61451-61452,61455-61457,61459-61464,61466-61467,61469-61470,61476-61477,61479,61481-61482,61485,61487,61490,61493-61494,61497,61499-61502,61505-61506,61508,61511-61514,61519,61521-61522,61530-61531,61533-61537,61541-61555,61557-61558,61561-61562,61566-61569,61572-61574,61578-61579,61583-61584,61588-61589,61592,61594,61598-61601,61603-61604,61607-61612,61617,61619-61620,61624,61626,61628-61630,61635-61638,61640-61643,61645,61648,61653-61655,61659-61662,61664,61666,61668-61671,61673,61675,61679-61680,61682,61685-61686,61689-61695,61697-61699,61701-61703,61706,61710,61713,61717,61723,61726-61730,61736,61738,61740,61742,61745-61752,61754-61760,61762-61764,61768,61770-61772,61774-61775,61784-61787,61789-61792,61794-61795,61797-61806,61808-61809,61811-61812,61814-61819,61824,61826-61833,61835-61840,61843-61845,61848,61850,61854-61862,61865-61866,61868,61872-61873,61876-61877,61883-61888,61890-61891,61893-61899,61901-61903,61905-61912,61914,61917,61920-61921,61927,61930,61932-61934,61939,61941-61942,61944-61951,61955,61960-61963,61980,61982-61983,61991,61994-61996,62001-62003,62008-62010,62016-62017,62022,62024,62027,62031-62034,62041,62045-62046,62048,62050-62051,62055-62066,62068-62074,62076-62078 via svnmerge from
      svn+ssh://pythondev@svn.python.org/python/trunk
      
      ........
        r62048 | georg.brandl | 2008-03-29 23:53:55 -0700 (Sat, 29 Mar 2008) | 2 lines
      
        Adapt test_ast to the new ExceptHandler type.
      ........
        r62050 | georg.brandl | 2008-03-30 00:09:22 -0700 (Sun, 30 Mar 2008) | 2 lines
      
        Convert test_ast to unittest and add a test for r62049.
      ........
        r62051 | georg.brandl | 2008-03-30 12:00:49 -0700 (Sun, 30 Mar 2008) | 2 lines
      
        Make _fields attr for no fields consistent with _attributes attr.
      ........
        r62059 | georg.brandl | 2008-03-30 13:20:39 -0700 (Sun, 30 Mar 2008) | 2 lines
      
        Make AST nodes pickleable.
      ........
      97da44f7
    • Neal Norwitz's avatar
      Merged revisions 62047 via svnmerge from · 855fe60e
      Neal Norwitz authored
      svn+ssh://pythondev@svn.python.org/python/trunk
      
      ........
        r62047 | georg.brandl | 2008-03-29 23:40:17 -0700 (Sat, 29 Mar 2008) | 2 lines
      
        Patch #2511: Give the "excepthandler" AST item proper attributes by making it a Sum.
      ........
      855fe60e
    • Neal Norwitz's avatar
      Blocked revisions 62075 via svnmerge · d2154cc5
      Neal Norwitz authored
      ........
        r62075 | neal.norwitz | 2008-03-30 21:28:40 -0700 (Sun, 30 Mar 2008) | 1 line
      
        Use file.write instead of print to make it easier to merge with 3k.
      ........
      d2154cc5
    • Neal Norwitz's avatar
      Merged revisions 62049,62054 via svnmerge from · feef7b96
      Neal Norwitz authored
      svn+ssh://pythondev@svn.python.org/python/trunk
      
      ........
        r62049 | georg.brandl | 2008-03-30 00:01:47 -0700 (Sun, 30 Mar 2008) | 2 lines
      
        #2505: allow easier creation of AST nodes.
      ........
        r62054 | georg.brandl | 2008-03-30 12:43:27 -0700 (Sun, 30 Mar 2008) | 2 lines
      
        Fix error message -- "expects either 0 or 0 arguments"
      ........
      feef7b96
    • Neal Norwitz's avatar
      Merged revisions 62039-62042 via svnmerge from · 7633c842
      Neal Norwitz authored
      svn+ssh://pythondev@svn.python.org/python/trunk
      
      ........
        r62039 | georg.brandl | 2008-03-29 06:24:23 -0700 (Sat, 29 Mar 2008) | 3 lines
      
        Properly check for consistency with the third argument of
        compile() when compiling an AST node.
      ........
        r62040 | amaury.forgeotdarc | 2008-03-29 06:47:05 -0700 (Sat, 29 Mar 2008) | 5 lines
      
        The buildbot "x86 W2k8 trunk" seems to hang in test_socket.
        http://www.python.org/dev/buildbot/trunk/x86%20W2k8%20trunk/builds/255/step-test/0
      
        Temporarily increase verbosity of this test.
      ........
        r62042 | amaury.forgeotdarc | 2008-03-29 07:53:05 -0700 (Sat, 29 Mar 2008) | 3 lines
      
        Still investigating on the hanging test_socket.
        the test itself doesn't do anything on windows, focus on setUp and tearDown.
      ........
      7633c842
    • Neal Norwitz's avatar
      Blocked revisions 62020 via svnmerge · 56678bf1
      Neal Norwitz authored
      ........
        r62020 | amaury.forgeotdarc | 2008-03-28 15:43:38 -0700 (Fri, 28 Mar 2008) | 5 lines
      
        One #ifdef too much, and I broke all windows buildbots:
        in pyconfig.h, NTDDI_WIN2KSP4 is not *yet* defined, but will be at some point on some modules.
      
        Let this line even for older SDKs, they don't use it anyway.
      ........
      56678bf1
    • Neal Norwitz's avatar
      Revert r62070 due to syntax errors · ea7ad8f6
      Neal Norwitz authored
      ea7ad8f6
    • Neal Norwitz's avatar
      Revert r62070 due to syntax errors · cbff105b
      Neal Norwitz authored
      cbff105b
    • Benjamin Peterson's avatar
      8862e2ee
    • Benjamin Peterson's avatar
      Merged revisions 62021,62029,62035-62038,62043-62044,62052-62053 via svnmerge from · 21dd8d00
      Benjamin Peterson authored
      svn+ssh://pythondev@svn.python.org/python/trunk
      
      ........
        r62021 | benjamin.peterson | 2008-03-28 18:11:01 -0500 (Fri, 28 Mar 2008) | 2 lines
      
        NIL => NULL
      ........
        r62029 | amaury.forgeotdarc | 2008-03-28 20:42:31 -0500 (Fri, 28 Mar 2008) | 3 lines
      
        Correctly call the base class tearDown();
        otherwise running test_logging twice produce the errors we see on all buildbots
      ........
        r62035 | raymond.hettinger | 2008-03-29 05:42:07 -0500 (Sat, 29 Mar 2008) | 1 line
      
        Be explicit about what efficient means.
      ........
        r62036 | georg.brandl | 2008-03-29 06:46:18 -0500 (Sat, 29 Mar 2008) | 2 lines
      
        Fix capitalization.
      ........
        r62037 | amaury.forgeotdarc | 2008-03-29 07:42:54 -0500 (Sat, 29 Mar 2008) | 5 lines
      
        lib2to3 should install a logging handler only when run as a main program,
        not when used as a library.
      
        This may please the buildbots, which fail when test_lib2to3 is run before test_logging.
      ........
        r62043 | benjamin.peterson | 2008-03-29 10:24:25 -0500 (Sat, 29 Mar 2008) | 3 lines
      
        #2503 make singletons compared with "is" not == or !=
        Thanks to Wummel for the patch
      ........
        r62044 | gerhard.haering | 2008-03-29 14:11:52 -0500 (Sat, 29 Mar 2008) | 2 lines
      
        Documented the lastrowid attribute.
      ........
        r62052 | benjamin.peterson | 2008-03-30 14:35:10 -0500 (Sun, 30 Mar 2008) | 2 lines
      
        Updated README regarding doc formats
      ........
        r62053 | georg.brandl | 2008-03-30 14:41:39 -0500 (Sun, 30 Mar 2008) | 2 lines
      
        The other download formats will be available for 2.6 too.
      ........
      21dd8d00
    • Jeffrey Yasskin's avatar
      Blocked revisions 62067 via svnmerge · 346ab325
      Jeffrey Yasskin authored
      ........
        r62067 | jeffrey.yasskin | 2008-03-30 17:35:53 -0700 (Sun, 30 Mar 2008) | 2 lines
      
        Block the sys.exc_clear -3 warning from threading.py.
      ........
      346ab325
  6. 30 Mar, 2008 3 commits
    • Neal Norwitz's avatar
      Blocked revisions 62023,62025,62028 via svnmerge · 95969421
      Neal Norwitz authored
      ........
        r62023 | amaury.forgeotdarc | 2008-03-28 17:44:58 -0700 (Fri, 28 Mar 2008) | 5 lines
      
        Try to understand why most buildbots suddenly turned to red.
        Undo the only change that might have unexpected effects.
      
        To be followed.
      ........
        r62025 | amaury.forgeotdarc | 2008-03-28 17:49:07 -0700 (Fri, 28 Mar 2008) | 2 lines
      
        At least let the module compile
      ........
        r62028 | amaury.forgeotdarc | 2008-03-28 18:41:08 -0700 (Fri, 28 Mar 2008) | 2 lines
      
        Revert my experiment. I found one reason of failures in test_logging.
      ........
      95969421
    • Martin v. Löwis's avatar
      Blocked revisions 62019 via svnmerge · ebd00509
      Martin v. Löwis authored
      ........
        r62019 | amaury.forgeotdarc | 2008-03-28 22:55:29 +0100 (Fr, 28 Mär 2008) | 7 lines
      
        Repair compilation for Visual Studio 2005.
      
        I applied the same changes manually to VS7.1 and VC6 files; completely untested.
      
        (Christian, don't try too hard merging this change into py3k.
        It will be easier to do the same work again on the branch)
      ........
      ebd00509
    • Martin v. Löwis's avatar
      Merged revisions 62018 via svnmerge from · ae013cb4
      Martin v. Löwis authored
      svn+ssh://pythondev@svn.python.org/python/trunk
      
      ........
        r62018 | benjamin.peterson | 2008-03-28 21:56:00 +0100 (Fr, 28 Mär 2008) | 2 lines
      
        #2498 modernized try, except, finally statments in bdb
      ........
      ae013cb4