- 08 Aug, 2004 9 commits
-
-
Tim Peters authored
This got slammed in when find() was fixed to stop grabbing doctests from modules imported *by* the module being tested. Such tests cannot be expected to succeed, since they'll be run with the current module's globals. Dozens of Zope3 doctests were failing because of that. It wasn't clear why ignore_imports got added then. Maybe it's because some existing tests failed when the change was made. Whatever, it's a Bad Idea so it's gone now. The only use of it was exceedingly obscure, in test_doctest's "Duplicate Removal" test. It was "needed" there because, as an artifact of running a doctest inside a doctest, the func_globals of functions compiled in the second-level doctest don't match the module globals, and so the test-finder believed these functions were from a foreign module and skipped them. But that took a long time to figure out, and I actually understand some of this stuff <0.9 wink>. That problem was resolved by moving the source code for the second-level doctest into an actual module (test/doctest_aliases.py). The only remaining difficulty was that the test for the deprecated Tester.rundict() then failed, because the test finder doesn't take module=None at face value, trying to guess which module the user really intended then. Its guess wasn't appropriate for what Tester.rundict needs when module=None is given to *it*, which is "no, there is no module here, and I mean it". So now passing module=False means exactly that. This is hokey, but ignore_imports=False was really a hack to worm around that there was no way to tell the test-finder that module=None *sometimes* means what it says. There was no use case for the combination of passing a real module with ignore_imports=False.
-
Raymond Hettinger authored
* Facilitate reloads of local thread.
-
Tim Peters authored
-
Tim Peters authored
except internal tests.
-
Tim Peters authored
-
Tim Peters authored
Ripped out the docs for the new DocTestFinder's namefilter argument, and renamed it to _namefilter; this only existed to support isprivate. Removed the new DocTestFinder's objfilter argument. No point adding more cruft to a broken filtering design.
-
Tim Peters authored
-
Tim Peters authored
That's the title of the report, but the hole was probably plugged since Python 2.0. See corresponding checkin to PC/getpathp.c: a crucial precondition for joinpath() was neither documented nor verified, and there are so many callers with so many conditional paths that no "eyeball analysis" is satisfactory. Now Python dies with a fatal error if the precondition isn't satisfied, instead of allowing a buffer overrun. NOT TESTED! The Windows version of the patch was, but not this one. I don't feel like waiting for someone to notice the patch I attached to the bug report. If it doesn't compile, sorry, but fix it <wink>. If it does compile, it's "obviously correct".
-
Tim Peters authored
-
- 07 Aug, 2004 31 commits
-
-
Andrew M. Kuchling authored
-
Andrew M. Kuchling authored
-
Andrew M. Kuchling authored
-
Andrew M. Kuchling authored
-
Armin Rigo authored
-
Michael W. Hudson authored
[ 777659 ] Uninitialized variable used in Tools/faqwiz/faqwiz.py with help from jlgijsbers on #python-dev IRC.
-
Armin Rigo authored
hack: it would resize *interned* strings in-place! This occurred because their reference counts do not have their expected value -- stringobject.c hacks them. Mea culpa.
-
Armin Rigo authored
as discussed on IRC. The equivalent tests for the new behavior are in test_builtin.py.
-
Andrew M. Kuchling authored
-
Andrew M. Kuchling authored
PyObject* o -> PyObject *o to be consistent with the rest of the file - Correct markup for Py_True - Remove duplicate description of PyBool_Check
-
Andrew M. Kuchling authored
-
Andrew M. Kuchling authored
[Bug #914375] Crude modulefinder docs, but the module's code is very hard to read and it's not clear which bits are public and which aren't. The module's author should really be doing this (and using docstrings in the code, too)
-
Michael W. Hudson authored
-
Armin Rigo authored
-
Jeremy Hylton authored
This test is insanely slow, so it requires a resource. On my machine, it also appears to dump core. I think the problem is a stack overflow, but haven't been able to confirm.
-
Andrew M. Kuchling authored
-
Jeremy Hylton authored
Don't generate code for asserts in -O mode.
-
Jeremy Hylton authored
interning were not clear here -- a subclass could be mutable, for example -- and had bugs. Explicitly interning a subclass of string via intern() will raise a TypeError. Internal operations that attempt to intern a string subclass will have no effect. Added a few tests to test_builtin that includes the old buggy code and verifies that calls like PyObject_SetAttr() don't fail. Perhaps these tests should have gone in test_string.
-
Andrew M. Kuchling authored
-
Tim Peters authored
This was probably fixed in rev 1.32 of getpath.c, but there are so many paths thru the code that invoke joinpath() it's not at all obvious that it *is* fixed. It doesn't help confidence that a crucial precondition for calling joinpath() was neither documented nor verified. It is now, and joinpath() will barf with a fatal error now rather than overrun the buffer, if the precondition isn't met. Note that this patch only changes the Windows flavor. I attached another patch to the bug report for the POSIX flavor (which I can't test conveniently).
-
Andrew M. Kuchling authored
-
Andrew M. Kuchling authored
-
Andrew M. Kuchling authored
-
Michael W. Hudson authored
[ 991812 ] PyArg_ParseTuple can miss errors with warnings as exceptions as suggested in the report. This is definitely a 2.3 candidate (as are most of the checkins I've made in the last month...)
-
Andrew M. Kuchling authored
-
Andrew M. Kuchling authored
-
Jeremy Hylton authored
The change to use the newer httplib interface admitted the possibility that we'd get an HTTP/1.1 chunked response, but the code didn't handle it correctly. The raw socket object can't be pass to addinfourl(), because it would read the undecoded response. Instead, addinfourl() must call HTTPResponse.read(), which will handle the decoding. One extra wrinkle is that the HTTPReponse object can't be passed to addinfourl() either, because it doesn't implement readline() or readlines(). As a quick hack, use socket._fileobject(), which implements those methods on top of a read buffer. (suggested by mwh) Finally, add some tests based on test_urllibnet. Thanks to Andrew Sawyers for originally reporting the chunked problem.
-
Michael W. Hudson authored
[ 1000841 ] "make pdf" failure w/ 2.4 docs in the suggested way, by uglifying a URL.
-
Andrew M. Kuchling authored
-
Andrew M. Kuchling authored
-
Michael W. Hudson authored
[ 1003863 ] adds an index entry for __all__ to the tutorial
-