1. 10 Oct, 2001 4 commits
    • Jeremy Hylton's avatar
      Fix two memory leaks in socket.ssl(). · f86d63e4
      Jeremy Hylton authored
      XXX [1] These changes aren't tested very thoroughly, because regrtest
      doesn't do any SSL tests.  I've done some trivial tests on my own, but
      don't really know how to use the key and cert files.  In one case, an
      SSL-level error causes Python to dump core.  I'll get the fixed in the
      next round of changes.
      
      XXX [2] The checkin removes the x_attr member of the SSLObject struct.
      I'm not sure if this is kosher for backwards compatibility at the
      binary level.  Perhaps its safer to keep the member but keep it
      assigned to NULL.
      
      And the leaks?
      
      newSSLObject() called PyDict_New(), stored the result in x_attr
      without checking it, and later stored NULL in x_attr without doing
      anything to the dict.  So the dict always leaks.  There is no further
      reference to x_attr, so I just removed it completely.
      
      The error cases in newSSLObject() passed the return value of
      PyString_FromString() directly to PyErr_SetObject().
      PyErr_SetObject() expects a borrowed reference, so the string leaked.
      f86d63e4
    • Jeremy Hylton's avatar
      One more place where PyString_AsString() was used after a · 0407aeae
      Jeremy Hylton authored
      PyString_Check() had already succeeded.
      0407aeae
    • Jeremy Hylton's avatar
    • Jeremy Hylton's avatar
      SF patch [ #468662 ] Allow jython to complete test_grammar · 7d3dff2b
      Jeremy Hylton authored
      The behavior of co_varnames in the presence of nested argument tuples
      is not consistent across Python and Jython.  Test each platform
      separately.
      7d3dff2b
  2. 09 Oct, 2001 31 commits
  3. 08 Oct, 2001 5 commits