replace open(filepath).read() anti-pattern by code that safely and timely closes the file

Cython/Build/Dependencies.py

@@ -91,7 +91,14 @@ def file_hash(filename):
     path = os.path.normpath(filename.encode("UTF-8"))
     m = hashlib.md5(str(len(path)) + ":")
     m.update(path)
-    m.update(open(filename).read())
+    f = open(filename, 'rb')
+    try:
+        data = f.read(65000)
+        while data:
+            m.update(data)
+            data = f.read(65000)
+    finally:
+        f.close()
     return m.hexdigest()
 
 def parse_list(s):

Cython/Compiler/Main.py

@@ -309,7 +309,14 @@ class Context(object):
             position = e.args[2]
             encoding = e.args[0]
 
-            for idx, c in enumerate(open(source_filename, "rb").read()):
+            f = open(source_filename, "rb")
+            try:
+                byte_data = f.read()
+            finally:
+                f.close()
+
+            # FIXME: make this at least a little less inefficient
+            for idx, c in enumerate(byte_data):
                 if c in (ord('\n'), '\n'):
                     line += 1
                     column = 0

Cython/Compiler/Tests/TestParseTreeTransforms.py

@@ -271,13 +271,15 @@ class TestDebugTransform(DebuggerTestCase):
             assert 'puts' in spam_stepinto
             assert 'some_c_function' in spam_stepinto
         except:
-            print open(self.debug_dest).read()
+            f = open(self.debug_dest)
+            try:
+                print(f.read())
+            finally:
+                f.close()
             raise
 
 
 
-
-
 if __name__ == "__main__":
     import unittest
     unittest.main()

Cython/Debugger/Cygdb.py

@@ -35,35 +35,40 @@ def make_command_file(path_to_debug_info, prefix_code='', no_import=False):
 
     fd, tempfilename = tempfile.mkstemp()
     f = os.fdopen(fd, 'w')
-    f.write(prefix_code)
-    f.write('set breakpoint pending on\n')
-    f.write("set print pretty on\n")
-    f.write('python from Cython.Debugger import libcython, libpython\n')
-
-    if no_import:
-        # don't do this, this overrides file command in .gdbinit
-        # f.write("file %s\n" % sys.executable)
-        pass
-    else:
-        path = os.path.join(path_to_debug_info, "cython_debug", "interpreter")
-        interpreter = open(path).read()
-        f.write("file %s\n" % interpreter)
-        f.write('\n'.join('cy import %s\n' % fn for fn in debug_files))
-        f.write(textwrap.dedent('''\
-            python
-            import sys
+    try:
+        f.write(prefix_code)
+        f.write('set breakpoint pending on\n')
+        f.write("set print pretty on\n")
+        f.write('python from Cython.Debugger import libcython, libpython\n')
+
+        if no_import:
+            # don't do this, this overrides file command in .gdbinit
+            # f.write("file %s\n" % sys.executable)
+            pass
+        else:
+            path = os.path.join(path_to_debug_info, "cython_debug", "interpreter")
+            interpreter_file = open(path)
             try:
-                gdb.lookup_type('PyModuleObject')
-            except RuntimeError:
-                sys.stderr.write(
-                    'Python was not compiled with debug symbols (or it was '
-                    'stripped). Some functionality may not work (properly).\\n')
-            end
-
-            source .cygdbinit
-        '''))
-
-    f.close()
+                interpreter = interpreter_file.read()
+            finally:
+                interpreter_file.close()
+            f.write("file %s\n" % interpreter)
+            f.write('\n'.join('cy import %s\n' % fn for fn in debug_files))
+            f.write(textwrap.dedent('''\
+                python
+                import sys
+                try:
+                    gdb.lookup_type('PyModuleObject')
+                except RuntimeError:
+                    sys.stderr.write(
+                        'Python was not compiled with debug symbols (or it was '
+                        'stripped). Some functionality may not work (properly).\\n')
+                end
+
+                source .cygdbinit
+            '''))
+    finally:
+        f.close()
 
     return tempfilename