Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cython
Commits
e5aabcd1
Commit
e5aabcd1
authored
Aug 24, 2017
by
Stefan Behnel
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Pass current thread state into generator body instead of requesting it twice.
parent
1299cdcb
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
7 deletions
+13
-7
Cython/Compiler/Nodes.py
Cython/Compiler/Nodes.py
+2
-3
Cython/Utility/Coroutine.c
Cython/Utility/Coroutine.c
+11
-4
No files found.
Cython/Compiler/Nodes.py
View file @
e5aabcd1
...
@@ -4054,9 +4054,10 @@ class GeneratorBodyDefNode(DefNode):
...
@@ -4054,9 +4054,10 @@ class GeneratorBodyDefNode(DefNode):
self
.
declare_generator_body
(
env
)
self
.
declare_generator_body
(
env
)
def
generate_function_header
(
self
,
code
,
proto
=
False
):
def
generate_function_header
(
self
,
code
,
proto
=
False
):
header
=
"static PyObject *%s(__pyx_CoroutineObject *%s, PyObject *%s)"
%
(
header
=
"static PyObject *%s(__pyx_CoroutineObject *%s,
CYTHON_UNUSED PyThreadState *%s,
PyObject *%s)"
%
(
self
.
entry
.
func_cname
,
self
.
entry
.
func_cname
,
Naming
.
generator_cname
,
Naming
.
generator_cname
,
Naming
.
local_tstate_cname
,
Naming
.
sent_value_cname
)
Naming
.
sent_value_cname
)
if
proto
:
if
proto
:
code
.
putln
(
'%s; /* proto */'
%
header
)
code
.
putln
(
'%s; /* proto */'
%
header
)
...
@@ -4081,12 +4082,10 @@ class GeneratorBodyDefNode(DefNode):
...
@@ -4081,12 +4082,10 @@ class GeneratorBodyDefNode(DefNode):
self
.
generate_function_header
(
code
)
self
.
generate_function_header
(
code
)
closure_init_code
=
code
.
insertion_point
()
closure_init_code
=
code
.
insertion_point
()
# ----- Local variables
# ----- Local variables
code
.
putln
(
"__Pyx_PyThreadState_declare"
)
code
.
putln
(
"PyObject *%s = NULL;"
%
Naming
.
retval_cname
)
code
.
putln
(
"PyObject *%s = NULL;"
%
Naming
.
retval_cname
)
tempvardecl_code
=
code
.
insertion_point
()
tempvardecl_code
=
code
.
insertion_point
()
code
.
put_declare_refcount_context
()
code
.
put_declare_refcount_context
()
code
.
put_setup_refcount_context
(
self
.
entry
.
name
or
self
.
entry
.
qualified_name
)
code
.
put_setup_refcount_context
(
self
.
entry
.
name
or
self
.
entry
.
qualified_name
)
code
.
putln
(
"__Pyx_PyThreadState_assign"
)
profile
=
code
.
globalstate
.
directives
[
'profile'
]
profile
=
code
.
globalstate
.
directives
[
'profile'
]
linetrace
=
code
.
globalstate
.
directives
[
'linetrace'
]
linetrace
=
code
.
globalstate
.
directives
[
'linetrace'
]
if
profile
or
linetrace
:
if
profile
or
linetrace
:
...
...
Cython/Utility/Coroutine.c
View file @
e5aabcd1
...
@@ -357,7 +357,7 @@ static void __Pyx_Generator_Replace_StopIteration(CYTHON_UNUSED int in_async_gen
...
@@ -357,7 +357,7 @@ static void __Pyx_Generator_Replace_StopIteration(CYTHON_UNUSED int in_async_gen
//////////////////// CoroutineBase.proto ////////////////////
//////////////////// CoroutineBase.proto ////////////////////
//@substitute: naming
//@substitute: naming
typedef
PyObject
*
(
*
__pyx_coroutine_body_t
)(
PyObject
*
,
PyObject
*
);
typedef
PyObject
*
(
*
__pyx_coroutine_body_t
)(
PyObject
*
,
Py
ThreadState
*
,
Py
Object
*
);
typedef
struct
{
typedef
struct
{
PyObject_HEAD
PyObject_HEAD
...
@@ -636,6 +636,7 @@ static void __Pyx__Coroutine_AlreadyTerminatedError(CYTHON_UNUSED PyObject *gen,
...
@@ -636,6 +636,7 @@ static void __Pyx__Coroutine_AlreadyTerminatedError(CYTHON_UNUSED PyObject *gen,
static
static
PyObject
*
__Pyx_Coroutine_SendEx
(
__pyx_CoroutineObject
*
self
,
PyObject
*
value
,
int
closing
)
{
PyObject
*
__Pyx_Coroutine_SendEx
(
__pyx_CoroutineObject
*
self
,
PyObject
*
value
,
int
closing
)
{
__Pyx_PyThreadState_declare
__Pyx_PyThreadState_declare
PyThreadState
*
tstate
;
PyObject
*
retval
;
PyObject
*
retval
;
assert
(
!
self
->
is_running
);
assert
(
!
self
->
is_running
);
...
@@ -650,7 +651,13 @@ PyObject *__Pyx_Coroutine_SendEx(__pyx_CoroutineObject *self, PyObject *value, i
...
@@ -650,7 +651,13 @@ PyObject *__Pyx_Coroutine_SendEx(__pyx_CoroutineObject *self, PyObject *value, i
return
__Pyx_Coroutine_AlreadyTerminatedError
((
PyObject
*
)
self
,
value
,
closing
);
return
__Pyx_Coroutine_AlreadyTerminatedError
((
PyObject
*
)
self
,
value
,
closing
);
}
}
#if CYTHON_FAST_THREAD_STATE
__Pyx_PyThreadState_assign
__Pyx_PyThreadState_assign
tstate
=
$
local_tstate_cname
;
#else
tstate
=
__Pyx_PyThreadState_Current
;
#endif
if
(
self
->
exc_type
&&
self
->
exc_type
!=
Py_None
)
{
if
(
self
->
exc_type
&&
self
->
exc_type
!=
Py_None
)
{
#if CYTHON_COMPILING_IN_PYPY || CYTHON_COMPILING_IN_PYSTON
#if CYTHON_COMPILING_IN_PYPY || CYTHON_COMPILING_IN_PYSTON
// FIXME: what to do in PyPy?
// FIXME: what to do in PyPy?
...
@@ -661,9 +668,9 @@ PyObject *__Pyx_Coroutine_SendEx(__pyx_CoroutineObject *self, PyObject *value, i
...
@@ -661,9 +668,9 @@ PyObject *__Pyx_Coroutine_SendEx(__pyx_CoroutineObject *self, PyObject *value, i
PyTracebackObject
*
tb
=
(
PyTracebackObject
*
)
self
->
exc_traceback
;
PyTracebackObject
*
tb
=
(
PyTracebackObject
*
)
self
->
exc_traceback
;
PyFrameObject
*
f
=
tb
->
tb_frame
;
PyFrameObject
*
f
=
tb
->
tb_frame
;
Py_XINCREF
(
$
local_tstate_cnam
e
->
frame
);
Py_XINCREF
(
tstat
e
->
frame
);
assert
(
f
->
f_back
==
NULL
);
assert
(
f
->
f_back
==
NULL
);
f
->
f_back
=
$
local_tstate_cnam
e
->
frame
;
f
->
f_back
=
tstat
e
->
frame
;
}
}
#endif
#endif
// We were in an except handler when we left,
// We were in an except handler when we left,
...
@@ -678,7 +685,7 @@ PyObject *__Pyx_Coroutine_SendEx(__pyx_CoroutineObject *self, PyObject *value, i
...
@@ -678,7 +685,7 @@ PyObject *__Pyx_Coroutine_SendEx(__pyx_CoroutineObject *self, PyObject *value, i
}
}
self
->
is_running
=
1
;
self
->
is_running
=
1
;
retval
=
self
->
body
((
PyObject
*
)
self
,
value
);
retval
=
self
->
body
((
PyObject
*
)
self
,
tstate
,
value
);
self
->
is_running
=
0
;
self
->
is_running
=
0
;
return
retval
;
return
retval
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment