Do not redefine _USE_MATH_DEFINES in generated code (GH-4690)

Unconditionally adding `/D_USE_MATH_DEFINES` via cmdline triggers `-Wmacro-redefined` in cython-generated code.

Do not redefine _USE_MATH_DEFINES in generated code (GH-4690)
Unconditionally adding `/D_USE_MATH_DEFINES` via cmdline triggers `-Wmacro-redefined` in cython-generated code.
ef14c148 · Yuriy Chernyshov · Stefan Behnel · 2e38e238 · ef14c148
Commit ef14c148 authored Mar 22, 2022 by Yuriy Chernyshov Committed by Stefan Behnel Mar 21, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

Cython/Utility/ModuleSetupCode.c Cython/Utility/ModuleSetupCode.c +4 -2

No files found.
--- a/Cython/Utility/ModuleSetupCode.c
+++ b/Cython/Utility/ModuleSetupCode.c
@@ -963,8 +963,10 @@ static CYTHON_INLINE int __Pyx_PyErr_GivenExceptionMatches2(PyObject *err, PyObj

 /////////////// MathInitCode ///////////////

-#if defined(WIN32) || defined(MS_WINDOWS)
-  #define _USE_MATH_DEFINES
+#if defined(_WIN32) || defined(WIN32) || defined(MS_WINDOWS)
+  #if !defined(_USE_MATH_DEFINES)
+    #define _USE_MATH_DEFINES
+  #endif
 #endif
 #include <math.h>