- 29 Aug, 2018 5 commits
-
-
Vincent Pelletier authored
-
Vincent Pelletier authored
A pprofile run shows DateTime_or_None costing 3ms per value (including all callees). While this may seem low, it is common to receive hundreds of such values in single query results (ex: web mode document & webpage lookups), so the total time spent parting dates per query can become significantly larger than the time to execute the query itself. In the case of this measure setup, 504 dates were processed for a total of 1.5 seconds. DateTime is slow to parse strings because it cannot rely on a pre-known format. With MySQL/MariaDB, the format is know for those column types, so implement specific parsing to get better performance. On the same setup, pprofile run shows a parsing time of 123µs per value in DATETIME_to_DateTime_or_None, or 65ms total. DATE_to_DateTime_or_None should not deviate significantly from this.
-
Vincent Pelletier authored
For some reason, unit tests all broke while testing this revision. The relation between both is not clear to me (this code has worked for me). In doubt, I revert it for now. This reverts commit 0057272c.
-
Vincent Pelletier authored
getRelativeUrl and restrictedTraverse are expensive operations. Do not involve them pointlessly. Also, boolean evaluation of lists is a thing.
-
Vincent Pelletier authored
A pprofile run shows DateTime_or_None costing 3ms per value (including all callees). While this may seem low, it is common to receive hundreds of such values in single query results (ex: web mode document & webpage lookups), so the total time spent parting dates per query can become significantly larger than the time to execute the query itself. In the case of this measure setup, 504 dates were processed for a total of 1.5 seconds. DateTime is slow to parse strings because it cannot rely on a pre-known format. With MySQL/MariaDB, the format is know for those column types, so implement specific parsing to get better performance. On the same setup, pprofile run shows a parsing time of 72µs per value in DATETIME_to_DateTime_or_None, or 39ms total. DATE_to_DateTime_or_None should not deviate significantly from this.
-
- 28 Aug, 2018 1 commit
-
-
Jérome Perrin authored
Categories are member of themselves. When a category is renamed, the membership to self was already preserved thanks to nexedi/erp5@7f2e8eb2 , but this was not the case when a category was cut and pasted. There are two different cases: * When just created, a category is member of itself because this is the [default behavior](https://lab.nexedi.com/nexedi/erp5/blob/b705495de0f04645b7b3ad3b74c46de00c923876/product/CMFCategory/CategoryTool.py#L1193-1196) for categories not having categories set. In this case, it's dynamic. * When category has some categories set ( in `self.categories` ) - this happens for example after being renamed - then behavior is different and `self.categories` has to be updated. 7f2e8eb2 was handling properly the later case after a clone, but not in a cut and paste ( move ) scenario, because in this case "after clone" hook is not called. The first idea was to move the same hook at another level by overloading `_postCopy` but after some discussion and thinking, it seemed more logical to make sure `CategoryTool.setCategoryList` does not save categories membership to self, which is consistent in the way `CategoryTool.getCategoryList` adds the membership to self dynamically. This MR brings a few more tests, so that we can claim [#1900](https://nexedi.erp5.net/bug_module/1900) and [#704](https://nexedi.erp5.net/bug_module/704) are tested enough and close these old bugs. /reviewed-on nexedi/erp5!664
-
- 27 Aug, 2018 2 commits
-
-
Vincent Bechu authored
-
Richard authored
/reviewed-on nexedi/erp5!728
-
- 24 Aug, 2018 3 commits
-
-
Julien Muchembled authored
With commit babbf56f, some objects that were not indexed are now indexed, and this fails when these objects can't be indexed. An exemple is when a PythonScript is stored inside a Web Site: Traceback (innermost last): Module Products.CMFActivity.ActivityTool, line 1360, in invokeGroup traverse(method_id)(expanded_object_list) Module Products.ERP5Catalog.CatalogTool, line 939, in catalogObjectList super(CatalogTool, self).catalogObjectList(tmp_object_list, **m.kw) Module Products.ZSQLCatalog.ZSQLCatalog, line 828, in catalogObjectList catalog_value=catalog, Module Products.ERP5Catalog.CatalogTool, line 875, in wrapObjectList - __traceback_info__: (<PythonScript at /erp5/web_site_module/...>,) and document_object._getAcquireLocalRoles(): AttributeError: _getAcquireLocalRoles Before, such object was skipped because it does not have recursiveReindexObject.
-
Sven Franck authored
/reviewed-on !725
-
Vincent Bechu authored
-
- 23 Aug, 2018 14 commits
-
-
Vincent Bechu authored
-
Richard authored
-
Richard authored
[erp5_notebook]: add workflow to notebook, add erp5_dms as dependency, load iodide notebook in notebook module, change indentation of gadget_officejs_jio_notebook.js, update security settings
-
Richard authored
-
Richard authored
-
Richard authored
-
Richard authored
-
Laurent S authored
-
Laurent S authored
-
Laurent S authored
-
Laurent S authored
-
Laurent S authored
-
Yusei Tahara authored
-
Yusei Tahara authored
-
- 22 Aug, 2018 1 commit
-
-
Xiaowu Zhang authored
this commit should fix random plus button not present issue when open sort editor the reason is sort editor is opened before launcher call editor_panel.close() so wait for page loaded before open sort editor
-
- 21 Aug, 2018 6 commits
-
-
Vincent Bechu authored
-
Vincent Bechu authored
-
Vincent Bechu authored
-
Sebastien Robin authored
This hopefully fix the random issue of having test results not linked to a project. Indeed, distributor/createTestResult was called in two different times: - by the testnode, with the project title - by the runTestSuiteCommand, without the project title. This was not an issue most of the time, since the test result is already created. But if it was not there (like due to a cancelled test), a test result without project was created
-
Yusei Tahara authored
-
Yusei Tahara authored
-
- 20 Aug, 2018 2 commits
-
-
Yusei Tahara authored
erp5/tests/testERP5TestNode.py: Fix test_scalability_04_constructProfile. repository option is required for scalability test profile and it was added on commit 58d92a84.
-
Yusei Tahara authored
erp5/tests/testERP5TestNode.py: Fix test_zzzz_scalability_19_xxxx. prepareFrontendMasterInstance was removed on commit 4048ab39.
-
- 17 Aug, 2018 6 commits
-
-
Yusei Tahara authored
-
Yusei Tahara authored
erp5/util/testnode, scalability_test: Stop using a dummy frontend master and use host.vifib.net frontend with a valid SSL certificate instead. Always use https.
-
Yusei Tahara authored
erp5/util/testnode: hosting subscription url was not updated once it was set. As a result, since testnode watched an old destroyed instance, the next test never started. Thus don't store hosting subscription url. It changes from time to time.
-
Yusei Tahara authored
-
Yusei Tahara authored
-
Yusei Tahara authored
-