Commit 2849d246 authored by Jason Madden's avatar Jason Madden

Docs: We ship the greenlet header file, so it really isn't necessary at install time. [skip ci]

parent e519abff
......@@ -40,10 +40,6 @@ Build Changes
- Fix building from a source distribution (PyPI) without Cython
installed.
- greenlet is now required at build time. If it is not installed
before gevent is installed, gevent will be built twice when
installing from source.
Enhancements
------------
......
......@@ -49,7 +49,7 @@ from _setuplibev import CORE
from _setupares import ARES
# Get access to the greenlet header file.
# The sysconfig dir is not enough if we're in a virtualenv
# See https://github.com/pypa/pip/issues/4610
include_dirs = [sysconfig.get_path("include")]
......@@ -138,13 +138,19 @@ greenlet_requires = [
install_requires = greenlet_requires + []
# We use headers from greenlet, so it needs to be installed before we can compile.
# XXX: This doesn't quite seem to work: pip tries to build the wheel, which
# fails because greenlet is not installed (it's in a .eggs/ directory in the
# build directory, but that directory doesn't have includes). Then it installs greenlet,
# and builds gevent again, which works. Of course, now that we ship our own header,
# this is probably not completely necessary at all.
setup_requires = greenlet_requires + []
# We use headers from greenlet, so it needs to be installed before we
# can compile. If it isn't already installed before we start
# installing, and we say 'pip install gevent', a 'setup_requires'
# doesn't save us: pip happily downloads greenlet and drops it in a
# .eggs/ directory in the build directory, but that directory doesn't
# have includes! So we fail to build a wheel, pip goes ahead and
# installs greenlet, and builds gevent again, which works.
# Since we ship the greenlet header for buildout support (which fails
# to install the headers at all, AFAICS, we don't need to bother with
# the buggy setup_requires.)
setup_requires = []
if PYPY:
# These use greenlet/greenlet.h, which doesn't exist on PyPy
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment