Remove extra debugging, add another CPython2.7+libuv+Travis only crasher.

Makefile

@@ -81,11 +81,12 @@ test_prelim:
 	make bench
 
 # Folding from https://github.com/travis-ci/travis-rubies/blob/9f7962a881c55d32da7c76baefc58b89e3941d91/build.sh#L38-L44
+# 	echo -e "travis_fold:start:${GEVENT_CORE_CFFI_ONLY}\033[33;1m${GEVENT_CORE_CFFI_ONLY}\033[0m"
+# Make calls /bin/echo, which doesn't support the -e option, which is part of the bash builtin.
+# we need a python script to do this, or possible the GNU make shell function
 
 basictest: test_prelim
-	echo -e "travis_fold:start:${GEVENT_CORE_CFFI_ONLY}\033[33;1m${GEVENT_CORE_CFFI_ONLY}\033[0m"
 	cd src/greentest && GEVENT_RESOLVER=thread ${PYTHON} testrunner.py --config known_failures.py --quiet
-	echo -e "\ntravis_fold:end:${GEVENT_CORE_CFFI_ONLY}\r"
 
 alltest: basictest
 	cd src/greentest && GEVENT_RESOLVER=ares GEVENTARES_SERVERS=8.8.8.8 ${PYTHON} testrunner.py --config known_failures.py --ignore tests_that_dont_use_resolver.txt --quiet
@@ -104,7 +105,6 @@ allbackendtest:
 	make cffibackendtest
 
 cffibackendtest:
-	cd src/greentest && PYTHONFAULTHANDLER=1 GEVENT_CORE_CFFI_ONLY=libuv GEVENT_DEBUG=trace TRAVIS= ${PYTHON} test__threadpool.py -v TestJoinEmpty.test
 	GEVENT_CORE_CFFI_ONLY=libuv make alltest
 	GEVENT_CORE_CFFI_ONLY=libev make alltest
 

src/greentest/patched_tests_setup.py

@@ -230,6 +230,7 @@ if LIBUV:
                     # but only on CPython 2.7.14 on Travis. Cannot reproduce in
                     # 2.7.14 on macOS or 2.7.12 in local Ubuntu 16.04
                     'test_subprocess.POSIXProcessTestCase.test_close_fd_0',
+                    'test_subprocess.POSIXProcessTestCase.test_close_fds_0_1',
                 ]
 
     if PY3:
@@ -954,7 +955,6 @@ def disable_tests_in_source(source, filename):
         pattern = r"^([ \t]+)def " + testcase
         replacement = r"\1@_GEVENT_UTS.skip('Removed by patched_tests_setup: %s')\n" % (test,)
         replacement += r"\g<0>"
-        sb = source
         source, n = re.subn(pattern, replacement, source, 0, re.MULTILINE)
         print('Skipped %s (%d)' % (testcase, n), file=sys.stderr)
 

src/greentest/test__threadpool.py

@@ -282,6 +282,8 @@ class TestJoinEmpty(TestCase):
     @greentest.skipIf(greentest.PYPY and greentest.LIBUV and greentest.RUNNING_ON_TRAVIS,
                       "This sometimes appears to crash in PyPy2 5.9.0, "
                       "but never crashes on macOS or local Ubunto with same PyPy version")
+    # Running this test standalone doesn't crash PyPy, only when it's run
+    # as part of this whole file. Removing it does solve the crash though.
     def test(self):
         self.pool = ThreadPool(1)
         self.pool.join()