Commit da1b41af authored by Jason Madden's avatar Jason Madden

First attempt to workaround Python 2 errors on Travis with TestGeventOrg.

parent 3d84f82a
...@@ -228,12 +228,19 @@ class TestCase(greentest.TestCase): ...@@ -228,12 +228,19 @@ class TestCase(greentest.TestCase):
return gevent_result return gevent_result
def _normalize_result(self, result):
return result
def assertEqualResults(self, real_result, gevent_result, func, args): def assertEqualResults(self, real_result, gevent_result, func, args):
errors = [socket.gaierror, socket.herror, TypeError] errors = (socket.gaierror, socket.herror, TypeError)
if type(real_result) in errors and type(gevent_result) in errors: if isinstance(real_result, errors) and isinstance(gevent_result, errors):
if type(real_result) is not type(gevent_result): if type(real_result) is not type(gevent_result):
log('WARNING: error type mismatch: %r (gevent) != %r (stdlib)', gevent_result, real_result) log('WARNING: error type mismatch: %r (gevent) != %r (stdlib)', gevent_result, real_result)
return return
real_result = self._normalize_result(real_result)
gevent_result = self._normalize_result(gevent_result)
real_result_repr = repr(real_result) real_result_repr = repr(real_result)
gevent_result_repr = repr(gevent_result) gevent_result_repr = repr(gevent_result)
if real_result_repr == gevent_result_repr: if real_result_repr == gevent_result_repr:
...@@ -311,7 +318,13 @@ for ip, host in re.findall(r'^\s*(\d+\.\d+\.\d+\.\d+)\s+([^\s]+)', etc_hosts, re ...@@ -311,7 +318,13 @@ for ip, host in re.findall(r'^\s*(\d+\.\d+\.\d+\.\d+)\s+([^\s]+)', etc_hosts, re
class TestGeventOrg(TestCase): class TestGeventOrg(TestCase):
pass
def _normalize_result(self, result):
if isinstance(result, (list, tuple)):
# Attempt to account for round-robin DNS responses
# that return the same results in different orders
result = sorted(result)
return result
add(TestGeventOrg, 'gevent.org') add(TestGeventOrg, 'gevent.org')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment