Commit e52ac513 authored by Jason Madden's avatar Jason Madden

Disable that failing test on 3.8b4 for now.

parent 412d59d0
......@@ -2,6 +2,7 @@
from __future__ import absolute_import, print_function, division
import unittest
import sys
import gevent.testing as greentest
from gevent import core
......@@ -128,6 +129,12 @@ class TestWatchersDefault(TestWatchers):
"See https://ci.appveyor.com/project/denik/gevent/build/1.0.1380/job/lrlvid6mkjtyrhn5#L1103 "
"It has also timed out, but only on Appveyor CPython 3.6; local CPython 3.6 does not. "
"See https://ci.appveyor.com/project/denik/gevent/build/1.0.1414/job/yn7yi8b53vtqs8lw#L1523")
@greentest.skipIf(
greentest.LIBUV and greentest.RUNNING_ON_TRAVIS and sys.version_info == (3, 8, 0, 'beta', 4),
"Crashes on 3.8.0b4 on TravisCI. "
"(https://travis-ci.org/gevent/gevent/jobs/582031266#L215) "
"Unable to reproduce locally so far on macOS."
)
class TestWatchersDefaultDestroyed(TestWatchers):
def _makeOne(self):
......
......@@ -3,15 +3,15 @@
from gevent import monkey; monkey.patch_all()
import sys
import os
import array
import socket
import traceback
import time
import unittest
import gevent.testing as greentest
from functools import wraps
from gevent import get_hub
import gevent.testing as greentest
from gevent.testing import six
from gevent.testing import LARGE_TIMEOUT
from gevent.testing import support
......@@ -34,8 +34,7 @@ class Thread(_Thread):
try:
return target(*args, **kwargs)
except: # pylint:disable=bare-except
traceback.print_exc()
os._exit(2)
get_hub().throw(*sys.exc_info())
_Thread.__init__(self, target=errors_are_fatal, **kwargs)
self.start()
......@@ -91,18 +90,17 @@ class TestTCP(greentest.TestCase):
def accept_and_read():
conn = None
r = None
try:
conn, _ = self.listener.accept()
r = conn.makefile(mode='rb')
read_data.append(r.read())
r.flush()
r.close()
except: # pylint:disable=bare-except
server_exc_info.append(sys.exc_info())
finally:
if conn:
conn.close()
self.listener.close()
for f in (conn, r, self.listener):
if f is not None:
f.close()
server = Thread(target=accept_and_read)
client = self.create_connection(**client_args)
......@@ -114,9 +112,10 @@ class TestTCP(greentest.TestCase):
client.close()
server.join()
assert not server.is_alive()
if match_data is None:
match_data = self.long_data
self.assertEqual(read_data[0], match_data)
self.assertEqual(read_data, [match_data])
if server_exc_info:
six.reraise(*server_exc_info[0])
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment