Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gevent
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
gevent
Commits
e711bce4
Commit
e711bce4
authored
Jul 21, 2017
by
Jason Madden
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Skip the test on PyPy3 because the workaround hangs CPython3
parent
8473bc7e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
6 deletions
+13
-6
src/greentest/greentest.py
src/greentest/greentest.py
+6
-1
src/greentest/test_threading_2.py
src/greentest/test_threading_2.py
+7
-5
No files found.
src/greentest/greentest.py
View file @
e711bce4
...
...
@@ -118,7 +118,7 @@ else:
skipOnAppVeyor
=
_do_not_skip
if
PYPY3
and
RUNNING_ON_CI
:
# Same as above, for PyPy3.3-5.5-alpha and 3.5-5.7.1-beta
# Same as above, for PyPy3.3-5.5-alpha and 3.5-5.7.1-beta
and 3.5-5.8
skipOnPyPy3OnCI
=
unittest
.
skip
else
:
skipOnPyPy3OnCI
=
_do_not_skip
...
...
@@ -128,6 +128,11 @@ if PYPY:
else
:
skipOnPyPy
=
_do_not_skip
if
PYPY3
:
skipOnPyPy3
=
unittest
.
skip
else
:
skipOnPyPy3
=
_do_not_skip
EXPECT_POOR_TIMER_RESOLUTION
=
PYPY3
or
RUNNING_ON_APPVEYOR
class
ExpectedException
(
Exception
):
...
...
src/greentest/test_threading_2.py
View file @
e711bce4
...
...
@@ -470,7 +470,7 @@ class ThreadJoinOnShutdown(unittest.TestCase):
"""
self
.
_run_and_join
(
script
)
@
greentest
.
skipOnPyPy3
(
"Buffering issue."
)
def
test_3_join_in_forked_from_thread
(
self
):
# Like the test above, but fork() was called from a worker thread
# In the forked process, the main Thread object must be marked as stopped.
...
...
@@ -500,11 +500,13 @@ class ThreadJoinOnShutdown(unittest.TestCase):
w = threading.Thread(target=worker)
w.start()
# In PyPy3 5.8.0, if we don't wait on this top-level "thread"
# we never see "end of thread". It's not clear why, since that's being
# done in a child of this process.
w.join()
"""
# In PyPy3 5.8.0, if we don't wait on this top-level "thread", 'w',
# we never see "end of thread". It's not clear why, since that's being
# done in a child of this process. Yet in normal CPython 3, waiting on this
# causes the whole process to lock up (possibly because of some loop within
# the interpreter waiting on thread locks, like the issue described in threading.py
# for Python 3.4? in any case, it doesn't hang in Python 2.)
self
.
_run_and_join
(
script
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment