Patch subprocess by default. Fixes #466.

changelog.rst

@@ -41,6 +41,7 @@ Unreleased
   return True, supporting its use-case as an "infinite" or unbounded
   semaphore providing no exclusing, and allowing the idiom ``if
   sem.acquire(): ...``. PR #544 by Mouad Benchchaoui.
+- Patch ``subprocess`` by default in ``gevent.monkey.patch_all``. See #446.
 
 Release 1.0.2
 -------------

gevent/monkey.py

@@ -235,7 +235,7 @@ def patch_subprocess():
 
 
 def patch_all(socket=True, dns=True, time=True, select=True, thread=True, os=True, ssl=True, httplib=False,
-              subprocess=False, sys=False, aggressive=True, Event=False):
+              subprocess=True, sys=False, aggressive=True, Event=False):
     """Do all of the default monkey patching (calls every other function in this module."""
     # order is important
     if os:

gevent/subprocess.py

@@ -307,8 +307,8 @@ class Popen(object):
             self.stderr.close()
 
         self.wait()
-        return (None if stdout is None else stdout.value or '',
-                None if stderr is None else stderr.value or '')
+        return (None if stdout is None else stdout.value or b'',
+                None if stderr is None else stderr.value or b'')
 
     def poll(self):
         return self._internal_poll()