Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
gitlab-ce
Commits
04ece666
Commit
04ece666
authored
Jun 24, 2016
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add ci config class that represents a key value
parent
823970b5
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
62 additions
and
0 deletions
+62
-0
lib/gitlab/ci/config/node/key.rb
lib/gitlab/ci/config/node/key.rb
+18
-0
lib/gitlab/ci/config/node/validators.rb
lib/gitlab/ci/config/node/validators.rb
+10
-0
spec/lib/gitlab/ci/config/node/key_spec.rb
spec/lib/gitlab/ci/config/node/key_spec.rb
+34
-0
No files found.
lib/gitlab/ci/config/node/key.rb
0 → 100644
View file @
04ece666
module
Gitlab
module
Ci
class
Config
module
Node
##
# Entry that represents a key.
#
class
Key
<
Entry
include
Validatable
validations
do
validates
:config
,
key:
true
end
end
end
end
end
end
lib/gitlab/ci/config/node/validators.rb
View file @
04ece666
...
@@ -13,6 +13,16 @@ module Gitlab
...
@@ -13,6 +13,16 @@ module Gitlab
end
end
end
end
class
KeyValidator
<
ActiveModel
::
EachValidator
include
LegacyValidationHelpers
def
validate_each
(
record
,
attribute
,
value
)
unless
validate_string
(
value
)
record
.
errors
.
add
(
attribute
,
'should be a string or symbol'
)
end
end
end
class
TypeValidator
<
ActiveModel
::
EachValidator
class
TypeValidator
<
ActiveModel
::
EachValidator
def
validate_each
(
record
,
attribute
,
value
)
def
validate_each
(
record
,
attribute
,
value
)
type
=
options
[
:with
]
type
=
options
[
:with
]
...
...
spec/lib/gitlab/ci/config/node/key_spec.rb
0 → 100644
View file @
04ece666
require
'spec_helper'
describe
Gitlab
::
Ci
::
Config
::
Node
::
Key
do
let
(
:entry
)
{
described_class
.
new
(
config
)
}
describe
'validations'
do
context
'when entry config value is correct'
do
let
(
:config
)
{
'test'
}
describe
'#value'
do
it
'returns key value'
do
expect
(
entry
.
value
).
to
eq
'test'
end
end
describe
'#valid?'
do
it
'is valid'
do
expect
(
entry
).
to
be_valid
end
end
end
context
'when entry value is not correct'
do
let
(
:config
)
{
[
'incorrect'
]
}
describe
'#errors'
do
it
'saves errors'
do
expect
(
entry
.
errors
)
.
to
include
'Key config should be a string or symbol'
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment