Commit 3aabed34 authored by Rubén Dávila's avatar Rubén Dávila

Fix bug that happened when replacing the Task list. #2296

REF: https://gitlab.com/gitlab-org/gitlab-ce/issues/2296#note_2724697
parent fa9f2dec
...@@ -31,7 +31,7 @@ module Taskable ...@@ -31,7 +31,7 @@ module Taskable
old_task = old_tasks[i] old_task = old_tasks[i]
next unless old_task next unless old_task
new_task.source == new_task.source && new_task.complete? != old_task.complete? new_task.source == old_task.source && new_task.complete? != old_task.complete?
end end
end end
......
...@@ -121,6 +121,25 @@ describe Issues::UpdateService do ...@@ -121,6 +121,25 @@ describe Issues::UpdateService do
expect(note).to be_nil expect(note).to be_nil
end end
end end
context 'when a Task list with a completed item is totally replaced' do
before do
update_issue({ description: "- [ ] Task 1\n- [X] Task 2" })
update_issue({ description: "- [ ] One\n- [ ] Two\n- [ ] Three" })
end
it 'does not create a system note referencing the position the old item' do
note = find_note('Marked the task **Two** as incomplete')
expect(note).to be_nil
end
it 'should not generate a new note at all' do
expect {
update_issue({ description: "- [ ] One\n- [ ] Two\n- [ ] Three" })
}.not_to change { Note.count }
end
end
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment