Commit 754c38bb authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets

Merge branch 'speed_up_migration' into 'master'

Speed up omniauth AddIdentityTable migration

https://dev.gitlab.org/gitlab/gitlabhq/issues/1810

See merge request !1315
parents 0e32b3c0 7d8dfccf
...@@ -8,9 +8,11 @@ class AddIdentityTable < ActiveRecord::Migration ...@@ -8,9 +8,11 @@ class AddIdentityTable < ActiveRecord::Migration
add_index :identities, :user_id add_index :identities, :user_id
User.where("provider IS NOT NULL").find_each do |user| execute <<eos
execute "INSERT INTO identities(provider, extern_uid, user_id) VALUES('#{user.provider}', '#{user.extern_uid}', '#{user.id}')" INSERT INTO identities (provider, extern_uid, user_id)
end SELECT provider, extern_uid, id FROM users
WHERE provider IS NOT NULL
eos
remove_column :users, :extern_uid remove_column :users, :extern_uid
remove_column :users, :provider remove_column :users, :provider
...@@ -20,12 +22,16 @@ class AddIdentityTable < ActiveRecord::Migration ...@@ -20,12 +22,16 @@ class AddIdentityTable < ActiveRecord::Migration
add_column :users, :extern_uid, :string add_column :users, :extern_uid, :string
add_column :users, :provider, :string add_column :users, :provider, :string
User.where("id IN(SELECT user_id FROM identities)").find_each do |user| if ActiveRecord::Base.connection.adapter_name == 'PostgreSQL'
identity = user.identities.last execute <<eos
user.extern_uid = identity.extern_uid UPDATE users u
user.provider = identity.provider SET provider = i.provider, extern_uid = i.extern_uid
user.save FROM identities i
end WHERE i.user_id = u.id
eos
else
execute "UPDATE users u, identities i SET u.provider = i.provider, u.extern_uid = i.extern_uid WHERE u.id = i.user_id"
end
drop_table :identities drop_table :identities
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment