Merge branch 'fix-bad-fetch' into 'master'

Don't fetch any tags from a forked repo

Closes #13957

See merge request !3504
Signed-off-by: Rémy Coutable <remy@rymai.me>

CHANGELOG

 Please view this file on the master branch, on stable branches it's out of date.
 
-v 8.6.0 (unreleased)
-  - Contributions to forked projects are included in calendar
-  - Improve the formatting for the user page bio (Connor Shea)
-  - Fix issue when pushing to projects ending in .wiki
-  - Fix avatar stretching by providing a cropping feature (Johann Pardanaud)
-  - Don't load all of GitLab in mail_room
-  - Strip leading and trailing spaces in URL validator (evuez)
-  - Return empty array instead of 404 when commit has no statuses in commit status API
-  - Update documentation to reflect Guest role not being enforced on internal projects
-  - Allow search for logged out users
-  - Don't show Issues/MRs from archived projects in Groups view
-  - Increase the notes polling timeout over time (Roberto Dip)
-  - Add shortcut to toggle markdown preview (Florent Baldino)
-  - Show labels in dashboard and group milestone views
-  - Add main language of a project in the list of projects (Tiago Botelho)
-  - Add ability to show archived projects on dashboard, explore and group pages
+v 8.5.9
+  - Don't attempt to fetch any tags from a forked repo (Stan Hu). !3504
 
 v 8.5.8
   - Bump Git version requirement to 2.7.4

app/models/repository.rb

@@ -709,7 +709,7 @@ class Repository
   end
 
   def fetch_ref(source_path, source_ref, target_ref)
-    args = %W(#{Gitlab.config.git.bin_path} fetch -f #{source_path} #{source_ref}:#{target_ref})
+    args = %W(#{Gitlab.config.git.bin_path} fetch --no-tags -f #{source_path} #{source_ref}:#{target_ref})
     Gitlab::Popen.popen(args, path_to_repo)
   end