Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
gitlab-ce
Commits
f261be09
Commit
f261be09
authored
May 27, 2016
by
Fatih Acet
Committed by
Z.J. van de Weg
Jun 06, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Award emoji implementation for notes.
parent
eaff5afc
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
92 additions
and
65 deletions
+92
-65
app/assets/javascripts/awards_handler.coffee
app/assets/javascripts/awards_handler.coffee
+88
-63
app/views/award_emoji/_awards_block.html.haml
app/views/award_emoji/_awards_block.html.haml
+1
-1
app/views/projects/notes/_note.html.haml
app/views/projects/notes/_note.html.haml
+3
-1
No files found.
app/assets/javascripts/awards_handler.coffee
View file @
f261be09
...
@@ -6,35 +6,43 @@ class @AwardsHandler
...
@@ -6,35 +6,43 @@ class @AwardsHandler
$
(
document
)
$
(
document
)
.
off
'click'
,
'.js-add-award'
.
off
'click'
,
'.js-add-award'
.
on
'click'
,
'.js-add-award'
,
(
e
vent
)
=>
.
on
'click'
,
'.js-add-award'
,
(
e
)
=>
e
vent
.
stopPropagation
()
e
.
stopPropagation
()
e
vent
.
preventDefault
()
e
.
preventDefault
()
@
showEmojiMenu
$
(
e
vent
.
currentTarget
)
@
showEmojiMenu
$
(
e
.
currentTarget
)
$
(
'html'
).
on
'click'
,
(
event
)
->
$
(
'html'
).
on
'click'
,
(
e
)
->
unless
$
(
event
.
target
).
closest
(
'.emoji-menu'
).
length
$target
=
$
e
.
target
unless
$target
.
closest
(
'.emoji-menu-content'
).
length
$
(
'.js-awards-block.current'
).
removeClass
'current'
unless
$target
.
closest
(
'.emoji-menu'
).
length
if
$
(
'.emoji-menu'
).
is
(
':visible'
)
if
$
(
'.emoji-menu'
).
is
(
':visible'
)
$
(
'.js-add-award.is-active'
).
removeClass
'is-active'
$
(
'.js-add-award.is-active'
).
removeClass
'is-active'
$
(
'.emoji-menu'
).
removeClass
'is-visible'
$
(
'.emoji-menu'
).
removeClass
'is-visible'
$
(
document
)
$
(
document
)
.
off
'click'
,
'.js-emoji-btn'
.
off
'click'
,
'.js-emoji-btn'
.
on
'click'
,
'.js-emoji-btn'
,
@
handleClick
.
on
'click'
,
'.js-emoji-btn'
,
(
e
)
=>
e
.
preventDefault
()
handleClick
:
(
e
)
=>
$target
=
$
e
.
currentTarget
emoji
=
$target
.
find
(
'.icon'
).
data
'emoji'
e
.
preventDefault
()
$target
.
closest
(
'.js-awards-block'
).
addClass
'current'
@
addAward
@
getAwardUrl
(),
emoji
emoji
=
$
(
e
.
currentTarget
).
find
(
'.icon'
).
data
'emoji'
@
getVotesBlock
().
addClass
'js-awards-block'
@
addAward
@
getAwardUrl
(),
emoji
showEmojiMenu
:
(
$addBtn
)
->
showEmojiMenu
:
(
$addBtn
)
->
$menu
=
$
(
'.emoji-menu'
)
$menu
=
$
'.emoji-menu'
if
$addBtn
.
hasClass
'note-emoji-button'
$addBtn
.
parents
(
'.note'
).
find
(
'.js-awards-block'
).
addClass
'current'
else
$addBtn
.
closest
(
'.js-awards-block'
).
addClass
'current'
if
$menu
.
length
if
$menu
.
length
$holder
=
$addBtn
.
closest
(
'.js-award-holder'
)
$holder
=
$addBtn
.
closest
(
'.js-award-holder'
)
...
@@ -68,7 +76,7 @@ class @AwardsHandler
...
@@ -68,7 +76,7 @@ class @AwardsHandler
createEmojiMenu
:
(
awardMenuUrl
,
callback
)
->
createEmojiMenu
:
(
awardMenuUrl
,
callback
)
->
$
.
get
awardMenuUrl
,
(
response
)
=
>
$
.
get
awardMenuUrl
,
(
response
)
-
>
$
(
'body'
).
append
response
$
(
'body'
).
append
response
callback
()
callback
()
...
@@ -94,11 +102,10 @@ class @AwardsHandler
...
@@ -94,11 +102,10 @@ class @AwardsHandler
addAward
:
(
awardUrl
,
emoji
,
checkMutuality
=
yes
)
->
addAward
:
(
awardUrl
,
emoji
,
checkMutuality
=
yes
)
->
emoji
=
@
normilizeEmojiName
(
emoji
)
emoji
=
@
normilizeEmojiName
emoji
@
postEmoji
awardUrl
,
emoji
,
=>
@
addAwardToEmojiBar
(
emoji
,
checkMutuality
)
$
(
'.js-awards-block-current'
).
removeClass
'js-awards-block-current'
@
postEmoji
awardUrl
,
emoji
,
=>
@
addAwardToEmojiBar
emoji
,
checkMutuality
$
(
'.emoji-menu'
).
removeClass
'is-visible'
$
(
'.emoji-menu'
).
removeClass
'is-visible'
...
@@ -108,25 +115,26 @@ class @AwardsHandler
...
@@ -108,25 +115,26 @@ class @AwardsHandler
@
checkMutuality
emoji
if
checkForMutuality
@
checkMutuality
emoji
if
checkForMutuality
@
addEmojiToFrequentlyUsedList
(
emoji
)
@
addEmojiToFrequentlyUsedList
(
emoji
)
emoji
=
@
normilizeEmojiName
(
emoji
)
emoji
=
@
normilizeEmojiName
(
emoji
)
$emojiBtn
=
@
findEmojiIcon
(
emoji
).
parent
()
$emojiBtn
=
@
findEmojiIcon
(
emoji
).
parent
()
if
$emojiBtn
.
length
>
0
if
$emojiBtn
.
length
>
0
if
@
isActive
(
$emojiBtn
)
if
@
isActive
$emojiBtn
@
decrementCounter
(
$emojiBtn
,
emoji
)
@
decrementCounter
$emojiBtn
,
emoji
else
else
counter
=
$emojiBtn
.
find
(
'.js-counter'
)
counter
=
$emojiBtn
.
find
'.js-counter'
counter
.
text
(
parseInt
(
counter
.
text
())
+
1
)
counter
.
text
parseInt
(
counter
.
text
())
+
1
$emojiBtn
.
addClass
(
'active'
)
$emojiBtn
.
addClass
'active'
@
addMeToUserList
(
emoji
)
@
addMeToUserList
emoji
else
else
@
createEmoji
(
emoji
)
@
getVotesBlock
().
removeClass
'hidden'
@
createEmoji
emoji
getVotesBlock
:
->
return
$
'.
awards.js-awards-block
'
getVotesBlock
:
->
return
$
'.
js-awards-block.current
'
getAwardUrl
:
->
@
getVotesBlock
().
data
'award-url'
getAwardUrl
:
->
return
@
getVotesBlock
().
data
'award-url'
checkMutuality
:
(
emoji
)
->
checkMutuality
:
(
emoji
)
->
...
@@ -135,8 +143,9 @@ class @AwardsHandler
...
@@ -135,8 +143,9 @@ class @AwardsHandler
if
emoji
in
[
'thumbsup'
,
'thumbsdown'
]
if
emoji
in
[
'thumbsup'
,
'thumbsdown'
]
mutualVote
=
if
emoji
is
'thumbsup'
then
'thumbsdown'
else
'thumbsup'
mutualVote
=
if
emoji
is
'thumbsup'
then
'thumbsdown'
else
'thumbsup'
selector
=
"[data-emoji=
#{
mutualVote
}
]"
isAlreadyVoted
=
$
(
"[data-emoji=
#{
mutualVote
}
]"
).
parent
().
hasClass
'active'
isAlreadyVoted
=
@
getVotesBlock
().
find
(
selector
).
parent
().
hasClass
'active'
@
addAward
awardUrl
,
mutualVote
,
no
if
isAlreadyVoted
@
addAward
awardUrl
,
mutualVote
,
no
if
isAlreadyVoted
...
@@ -144,28 +153,35 @@ class @AwardsHandler
...
@@ -144,28 +153,35 @@ class @AwardsHandler
decrementCounter
:
(
$emojiBtn
,
emoji
)
->
decrementCounter
:
(
$emojiBtn
,
emoji
)
->
isntNoteBody
=
$emojiBtn
.
closest
(
'.note-body'
).
length
is
0
counter
=
$
(
'.js-counter'
,
$emojiBtn
)
counterNumber
=
parseInt
(
counter
.
text
())
if
!
isntNoteBody
counter
=
$
(
'.js-counter'
,
$emojiBtn
)
# If this is a note body, we just hide the award emoji row like the initial state
counterNumber
=
parseInt
(
counter
.
text
())
$emojiBtn
.
closest
(
'.js-awards-block'
).
addClass
'hidden'
if
counterNumber
>
1
if
counterNumber
>
1
counter
.
text
(
counterNumber
-
1
)
counter
.
text
(
counterNumber
-
1
)
@
removeMeFromUserList
(
$emojiBtn
,
emoji
)
@
removeMeFromUserList
(
$emojiBtn
,
emoji
)
else
if
(
emoji
==
'thumbsup'
||
emoji
==
'thumbsdown'
)
&&
isntNoteBody
else
if
emoji
is
'thumbsup'
or
emoji
is
'thumbsdown'
$emojiBtn
.
tooltip
(
'destroy'
)
$emojiBtn
.
tooltip
(
'destroy'
)
counter
.
text
(
'0'
)
counter
.
text
(
'0'
)
@
removeMeFromUserList
(
$emojiBtn
,
emoji
)
@
removeMeFromUserList
(
$emojiBtn
,
emoji
)
@
removeEmoji
$emojiBtn
if
$emojiBtn
.
parents
(
'.note'
).
length
else
else
$emojiBtn
.
tooltip
(
'destroy'
)
@
removeEmoji
$emojiBtn
$emojiBtn
.
remove
()
$emojiBtn
.
removeClass
(
'active'
)
$emojiBtn
.
removeClass
(
'active'
)
removeEmoji
:
(
$emojiBtn
)
->
$emojiBtn
.
tooltip
(
'destroy'
)
$emojiBtn
.
remove
()
$votesBlock
=
@
getVotesBlock
()
if
$votesBlock
.
find
(
'.js-emoji-btn'
).
length
is
0
$votesBlock
.
addClass
'hidden'
getAwardTooltip
:
(
$awardBlock
)
->
getAwardTooltip
:
(
$awardBlock
)
->
return
$awardBlock
.
attr
(
'data-original-title'
)
or
$awardBlock
.
attr
(
'data-title'
)
return
$awardBlock
.
attr
(
'data-original-title'
)
or
$awardBlock
.
attr
(
'data-title'
)
...
@@ -225,16 +241,12 @@ class @AwardsHandler
...
@@ -225,16 +241,12 @@ class @AwardsHandler
</button>"
</button>"
emoji_node
=
$
(
buttonHtml
)
emoji_node
=
$
(
buttonHtml
)
.
insertBefore
'.js-awards-block .js-award-holder:not(.js-award-action-btn)'
.
insertBefore
'.js-awards-block
.current
.js-award-holder:not(.js-award-action-btn)'
.
find
'.emoji-icon'
.
find
'.emoji-icon'
.
data
'emoji'
,
emoji
.
data
'emoji'
,
emoji
$
(
'.award-control'
).
tooltip
()
$
(
'.award-control'
).
tooltip
()
$
(
'.js-awards-block.current'
).
removeClass
'current'
$currentBlock
=
$
'.js-awards-block'
if
$currentBlock
.
is
'.hidden'
$currentBlock
.
removeClass
'hidden'
createEmoji
:
(
emoji
)
->
createEmoji
:
(
emoji
)
->
...
@@ -261,42 +273,53 @@ class @AwardsHandler
...
@@ -261,42 +273,53 @@ class @AwardsHandler
postEmoji
:
(
awardUrl
,
emoji
,
callback
)
->
postEmoji
:
(
awardUrl
,
emoji
,
callback
)
->
$
.
post
awardUrl
,
{
name
:
emoji
},
(
data
)
->
$
.
post
awardUrl
,
{
name
:
emoji
},
(
data
)
->
if
data
.
ok
callback
.
call
()
if
data
.
ok
callback
.
call
()
findEmojiIcon
:
(
emoji
)
->
findEmojiIcon
:
(
emoji
)
->
$
(
".js-awards-block.awards > .js-emoji-btn [data-emoji='
#{
emoji
}
']"
)
return
$
(
".js-awards-block.current > .js-emoji-btn [data-emoji='
#{
emoji
}
']"
)
scrollToAwards
:
->
scrollToAwards
:
->
$
(
'body, html'
).
animate
({
scrollTop
:
$
(
'.awards'
).
offset
().
top
-
80
},
200
)
normilizeEmojiName
:
(
emoji
)
->
options
=
scrollTop
:
$
(
'.awards'
).
offset
().
top
-
80
@
aliases
[
emoji
]
||
emoji
$
(
'body, html'
).
animate
options
,
200
normilizeEmojiName
:
(
emoji
)
->
return
@
aliases
[
emoji
]
or
emoji
addEmojiToFrequentlyUsedList
:
(
emoji
)
->
addEmojiToFrequentlyUsedList
:
(
emoji
)
->
frequently_used_emojis
=
@
getFrequentlyUsedEmojis
()
frequently_used_emojis
.
push
(
emoji
)
frequentlyUsedEmojis
=
@
getFrequentlyUsedEmojis
()
$
.
cookie
(
'frequently_used_emojis'
,
frequently_used_emojis
.
join
(
','
),
{
expires
:
365
})
frequentlyUsedEmojis
.
push
emoji
$
.
cookie
'frequently_used_emojis'
,
frequentlyUsedEmojis
.
join
(
','
),
{
expires
:
365
}
getFrequentlyUsedEmojis
:
->
getFrequentlyUsedEmojis
:
->
frequently_used_emojis
=
(
$
.
cookie
(
'frequently_used_emojis'
)
||
''
).
split
(
','
)
_
.
compact
(
_
.
uniq
(
frequently_used_emojis
))
frequentlyUsedEmojis
=
(
$
.
cookie
(
'frequently_used_emojis'
)
or
''
).
split
(
','
)
return
_
.
compact
_
.
uniq
frequentlyUsedEmojis
renderFrequentlyUsedBlock
:
->
renderFrequentlyUsedBlock
:
->
if
$
.
cookie
(
'frequently_used_emojis'
)
frequently_used_emojis
=
@
getFrequentlyUsedEmojis
()
if
$
.
cookie
'frequently_used_emojis'
frequentlyUsedEmojis
=
@
getFrequentlyUsedEmojis
()
ul
=
$
(
"<ul class='clearfix emoji-menu-list'>"
)
ul
=
$
(
"<ul class='clearfix emoji-menu-list'>"
)
for
emoji
in
frequently
_used_e
mojis
for
emoji
in
frequently
UsedE
mojis
$
(
".emoji-menu-content [data-emoji='
#{
emoji
}
']"
).
closest
(
'li'
).
clone
().
appendTo
(
ul
)
$
(
".emoji-menu-content [data-emoji='
#{
emoji
}
']"
).
closest
(
'li'
).
clone
().
appendTo
(
ul
)
$
(
'input.emoji-search'
).
after
(
ul
).
after
(
$
(
'<h5>'
).
text
(
'Frequently used'
))
$
(
'input.emoji-search'
).
after
(
ul
).
after
(
$
(
'<h5>'
).
text
(
'Frequently used'
))
setupSearch
:
->
setupSearch
:
->
$
(
'input.emoji-search'
).
on
'keyup'
,
(
ev
)
=>
$
(
'input.emoji-search'
).
on
'keyup'
,
(
ev
)
=>
term
=
$
(
ev
.
target
).
val
()
term
=
$
(
ev
.
target
).
val
()
...
@@ -313,5 +336,7 @@ class @AwardsHandler
...
@@ -313,5 +336,7 @@ class @AwardsHandler
else
else
$
(
'.emoji-menu-content'
).
children
().
show
()
$
(
'.emoji-menu-content'
).
children
().
show
()
searchEmojis
:
(
term
)
->
searchEmojis
:
(
term
)
->
$
(
".emoji-menu-content [data-emoji*='
#{
term
}
']"
).
closest
(
'li'
).
clone
()
$
(
".emoji-menu-content [data-emoji*='
#{
term
}
']"
).
closest
(
'li'
).
clone
()
app/views/award_emoji/_awards_block.html.haml
View file @
f261be09
...
@@ -11,7 +11,7 @@
...
@@ -11,7 +11,7 @@
gl
.
awardMenuUrl
=
"
#{
emojis_path
}
"
gl
.
awardMenuUrl
=
"
#{
emojis_path
}
"
.award-menu-holder.js-award-holder
.award-menu-holder.js-award-holder
%button
.btn.award-control.js-add-award
{
type:
"button"
,
data:
{
award_menu_url:
emojis_path
}
}
%button
.btn.award-control.js-add-award
{
type:
"button"
}
=
icon
(
'smile-o'
,
class:
"award-control-icon award-control-icon-normal"
)
=
icon
(
'smile-o'
,
class:
"award-control-icon award-control-icon-normal"
)
=
icon
(
'spinner spin'
,
class:
"award-control-icon award-control-icon-loading"
)
=
icon
(
'spinner spin'
,
class:
"award-control-icon award-control-icon-loading"
)
%span
.award-control-text
%span
.award-control-text
...
...
app/views/projects/notes/_note.html.haml
View file @
f261be09
...
@@ -22,7 +22,7 @@
...
@@ -22,7 +22,7 @@
%span
.note-role
%span
.note-role
=
access
=
access
-
if
note_editable
-
if
note_editable
=
link_to
'#'
,
title:
'A
dd Reaction
'
,
class:
'note-emoji-button js-add-award js-note-emoji'
,
data:
{
position:
'right'
}
do
=
link_to
'#'
,
title:
'A
ward Emoji
'
,
class:
'note-emoji-button js-add-award js-note-emoji'
,
data:
{
position:
'right'
}
do
=
icon
(
'spinner spin'
)
=
icon
(
'spinner spin'
)
=
icon
(
'smile-o'
)
=
icon
(
'smile-o'
)
=
link_to
'#'
,
title:
'Edit comment'
,
class:
'note-action-button js-note-edit'
do
=
link_to
'#'
,
title:
'Edit comment'
,
class:
'note-action-button js-note-edit'
do
...
@@ -35,6 +35,8 @@
...
@@ -35,6 +35,8 @@
=
markdown
(
note
.
note
,
pipeline: :note
,
cache_key:
[
note
,
"note"
],
author:
note
.
author
)
=
markdown
(
note
.
note
,
pipeline: :note
,
cache_key:
[
note
,
"note"
],
author:
note
.
author
)
-
if
note_editable
-
if
note_editable
=
render
'projects/notes/edit_form'
,
note:
note
=
render
'projects/notes/edit_form'
,
note:
note
.note-awards
=
render
'award_emoji/awards_block'
,
awardable:
note
,
inline:
false
=
edited_time_ago_with_tooltip
(
note
,
placement:
'bottom'
,
html_class:
'note_edited_ago'
,
include_author:
true
)
=
edited_time_ago_with_tooltip
(
note
,
placement:
'bottom'
,
html_class:
'note_edited_ago'
,
include_author:
true
)
-
if
note
.
attachment
.
url
-
if
note
.
attachment
.
url
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment