- 08 Mar, 2016 9 commits
-
-
Yorick Peterse authored
The methods used for this are Repository#tag_count and Repository#branch_count which cache their output in Redis as well as memoizing it in an instance variable. Both methods have a corresponding methods/hooks to flush the caches at the right time.
-
Achilleas Pipinellis authored
update slack instructions the previous instructions no longer apply, there is no "Incoming WebHooks" row anymore. luckily there exists direct link to web hooks, so the previous steps aren't even neccessary See merge request !3052
-
Achilleas Pipinellis authored
add link to web hooks docs Add link to web hooks docs on custom hooks docs page. See merge request !3082
-
Yorick Peterse authored
adds language names to projects list [image attached] See merge request !3000
-
Achilleas Pipinellis authored
Deprecated GitLab CI API clean up Deprecated GitLab CI API clean up. The intent here is to clean up deprecated GitLab CI documentation leaving only relevant information. Since we merged `Ci::Project` to `Project` most of this documentation is outdated. Closes #13610 See merge request !3003
-
Achilleas Pipinellis authored
add bundle clean to upgrade docs This MR adds a bundle clean after installing new gems. Bundle clean removes old, not needed gems to keep the system clean. See merge request !2809
-
Achilleas Pipinellis authored
Added Troubleshooting information for most used services. This replaces the changes started at gitlab-com/www-gitlab-com!1603 I'd like to add similar troubleshooting information for EE only services, but that needs to happen on a different MR on the EE side. Probably after this one gets merged. cc @ernstvn @dblessing @balameb @cabargas @kelvinmutuma See merge request !3080
-
Achilleas Pipinellis authored
Document changes to the initial admin password Addresses https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3068#note_4117550 [ci skip] See merge request !3120
-
Robert Speicher authored
[ci skip]
-
- 07 Mar, 2016 31 commits
-
-
Douwe Maan authored
Remove redundant integration tests These three tests were essentially checking that adding a note to something updated its `noteable`'s `updated_at` attribute. This is well-tested Rails behavior and we shouldn't feel the need to write an integration test to verify it. At most we should be ensuring that the association definition adds the `touch: true` option, which we now do in Note's unit test. See merge request !3117
-
Douwe Maan authored
Set cache headers for raw blobs This changes allows browsers and (in the case of public projects) proxy caches to cache raw Git blob responses. See merge request !3113
-
Patricio Cano authored
[ci skip]
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
removes automatic setting of main_language to project for it to set a main language you have now to make a commit to the project
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
Robert Speicher authored
These three tests were essentially checking that adding a note to something updated its `noteable`'s `updated_at` attribute. This is well-tested Rails behavior and we shouldn't feel the need to write an integration test to verify it. At most we should be ensuring that the association definition adds the `touch: true` option, which we now do in Note's unit test.
-
Douwe Maan authored
Labels should be visible in dashboard and group milestone views Closes #13621 See merge request !2931
-
Jacob Vosmaer authored
-
Christian Mehlmauer authored
-
Jacob Vosmaer authored
-
Jacob Vosmaer authored
-
Douwe Maan authored
Add support for cross project references for labels ## Summary Support for cross project references for labels. ## Rationale 1. Cross project label references are currently not supported in GitLab 1. `to_reference` method signature in `Label` model breaks the abstraction introduced in `Referable`. `concerns/referable.rb: def to_reference(_from_project = nil)` Signatures: ``` label.rb: def to_reference(format = :id) commit_range.rb: def to_reference(from_project = nil) commit.rb: def to_reference(from_project = nil) external_issue.rb: def to_reference(_from_project = nil) group.rb: def to_reference(_from_project = nil) issue.rb: def to_reference(from_project = nil) merge_request.rb: def to_reference(from_project = nil) milestone.rb: def to_reference(from_project = nil) project.rb: def to_reference(_from_project = nil) snippet.rb: def to_reference(from_project = nil) user.rb: def to_reference(_from_project = nil) ``` This MR suggests using `def to_reference(from_project = nil, format: :id)` which makes use of keyword arguments and preserves abstract interface. 1. We need support for cross project label references when we want to move issue to another project It may happen that issue description, system notes or comments contain reference to label and this reference will be invalid after moving issue to another project and will not be displayed correctly unless we have support for cross project references. Merge request that needs this feature: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2831 I think that cross project label references may be useful, (example: `Hey, see our issues for CI in GitLab CE! - gitab-org/gitlab-ce~"CI"`). cc @JobV @DouweM @rspeicher See merge request !2966
-
Douwe Maan authored
More Factory cleanup Addresses nitpicks from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2847 See merge request !3108
-
Douwe Maan authored
Indicate when an MR diverged from the target branch This adds an indicator to the "Merge MR" box, to tell if and how much an MR diverged from its target branch. For instance, consider an MR to merge the branch `feature` into `master`. Some other commits were added to `master` since `feature` was created, and the two branches diverged. ```text o master | o o feature | | o o | / o ``` In this case, there will be a label in the MR Merge box stating: > This MR is by 3 commits behind the target branch `master`. ## Screenshots ### The branch diverged from the target (UI Proposal) ![UI_suggestion_1](/uploads/cd5bee3959e68026ec7d5097259d53f4/UI_suggestion_1.png) ### The branch diverged from the target (alternative UI Proposal) ![UI_suggestion_2](/uploads/f36977101b59a610850e129837dfbc83/UI_suggestion_2.png) ## How is this useful? - In a _rebase-workflow_ (MR are preferably rebased before being merged), the reviewer wants to know if an MR is rebased on the target branch before merging it. _With this indicator, the reviewer knows immediately if the branch is rebased, or if she needs to ask the committer to rebase its branch._ <br> - To keep the git history readable, a team prefers to avoid merging branches that really lag a lot behind the target branch. Merging an MR that is 10 commits behind is fine, but 200 is too much. _With this indicator, the reviewer can see on the MR page if the branch is really far behind the target – or only a few commits behind._ ## Open questions We've been using this at @captaintrain for a few months now, and found it quite useful. I guess the open-questions are mostly: what UI would be the more adequate? Any thoughts on this, on the general usefulness and/or on the code? See merge request !2217
-
Douwe Maan authored
# Conflicts: # app/models/note.rb
-
Douwe Maan authored
Remove unused DiffLine model Added in Mar 2014. Only usage removed in Sep 2014. See merge request !3105
-
Douwe Maan authored
Make better use of the `Note#for_*?` methods We've got all these polymorphic type-checking methods, might as well use 'em everywhere it makes sense. See merge request !3106
-