Commit 2c5d04de authored by Jacob Vosmaer's avatar Jacob Vosmaer

Put authorized_keys.lock in the .ssh directory

parent c26647b9
v1.9.5
- Put authorized_keys.lock in the same directory as authorized_keys
v1.9.4 v1.9.4
- Use lock file when modify authorized_keys - Use lock file when modify authorized_keys
......
...@@ -92,6 +92,6 @@ class GitlabKeys ...@@ -92,6 +92,6 @@ class GitlabKeys
end end
def lock_file def lock_file
@lock_file ||= File.join(ROOT_PATH, "authorized_keys.lock") @lock_file ||= auth_file + '.lock'
end end
end end
...@@ -96,7 +96,10 @@ describe GitlabKeys do ...@@ -96,7 +96,10 @@ describe GitlabKeys do
end end
context "without file writing" do context "without file writing" do
before { Tempfile.stub(:open) } before do
Tempfile.stub(:open)
gitlab_keys.stub(:lock).and_yield
end
it "should log an rm-key event" do it "should log an rm-key event" do
$logger.should_receive(:info).with('Removing key key-741') $logger.should_receive(:info).with('Removing key key-741')
...@@ -146,6 +149,10 @@ describe GitlabKeys do ...@@ -146,6 +149,10 @@ describe GitlabKeys do
end end
describe :lock do describe :lock do
before do
GitlabKeys.any_instance.stub(lock_file: tmp_lock_file_path)
end
it "should raise exception if operation lasts more then timeout" do it "should raise exception if operation lasts more then timeout" do
key = GitlabKeys.new key = GitlabKeys.new
expect do expect do
...@@ -201,4 +208,8 @@ describe GitlabKeys do ...@@ -201,4 +208,8 @@ describe GitlabKeys do
def tmp_authorized_keys_path def tmp_authorized_keys_path
File.join(ROOT_PATH, 'tmp', 'authorized_keys') File.join(ROOT_PATH, 'tmp', 'authorized_keys')
end end
def tmp_lock_file_path
tmp_authorized_keys_path + '.lock'
end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment