Merge branch 'log-api-error' into 'master'

Log full Net::HTTP error.

See merge request !56

lib/gitlab_net.rb

@@ -101,7 +101,8 @@ class GitlabNet
 
     begin
       response = http.start { http.request(request) }
-    rescue 
+    rescue => e
+      $logger.warn "Failed to connect to internal API <#{method.to_s.upcase} #{url}>: #{e.inspect}"
       raise ApiUnreachableError 
     end
 

lib/gitlab_shell.rb

@@ -36,7 +36,6 @@ class GitlabShell
       puts "Welcome to GitLab, #{username}!"
     end
   rescue GitlabNet::ApiUnreachableError => ex
-    $logger.warn "gitlab-shell: Failed to connect to internal API"
     puts "Failed to authorize your Git request: internal API unreachable"
   rescue DisallowedCommandError => ex
     message = "gitlab-shell: Attempt to execute disallowed command <#{@origin_cmd}> by #{log_username}."

spec/gitlab_shell_spec.rb

@@ -150,11 +150,6 @@ describe GitlabShell do
       it "should not execute the command" do
         subject.should_not_receive(:exec_cmd)
       end
-
-      it "should log the failed connection" do
-        message = "gitlab-shell: Failed to connect to internal API"
-        $logger.should_receive(:warn).with(message)
-      end
     end
   end