• Bryan C. Mills's avatar
    cmd/go/internal/modfetch/codehost: replace a dubious call to semver.Max · 3f51350c
    Bryan C. Mills authored
    The documentation for RecentTag indicates that it returns an actual
    tag, not a canonicalized prefix+version blob equivalent to a tag,
    so the canonicalization due to semver.Max seems like a bug here.
    
    Fortunately, RecentTag is not currently ever actually used as a tag,
    so the removal of metadata does not result in a user-facing bug.
    Nonetheless, it may be a subtle source of confusion for maintainers
    in the future.
    
    Updates #32700
    
    Change-Id: I525423c1c0c7ec7c36c09e53b180034474f74e5a
    Reviewed-on: https://go-review.googlesource.com/c/go/+/212202
    Run-TryBot: Bryan C. Mills <bcmills@google.com>
    Reviewed-by: default avatarJay Conrod <jayconrod@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    3f51350c
query_test.go 8.94 KB