• isharipo's avatar
    cmd/asm: restrict x86 shift ops to 8bit args · 5b043abe
    isharipo authored
    Change "yshl" and "yshb" immediate oclass from Yi32 to Yu8.
    This forbids:
    - negative shift counts
    - shift counts that not fit into 8bit
    
    Affects:
      RCL{B,L,Q,W}
      RCR{B,L,Q,W}
      ROL{B,L,Q,W}
      ROR{B,L,Q,W}
      SAL{B,L,Q,W}
      SAR{B,L,Q,W}
      SHL{B,L,Q,W}
      SHR{B,L,Q,W}
    
    Issue #21528 has some additional context about this change.
    
    Change-Id: I60884cb2b41a860820889fcd878ca6f564006b4a
    Reviewed-on: https://go-review.googlesource.com/62190
    Run-TryBot: Iskander Sharipov <iskander.sharipov@intel.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarRuss Cox <rsc@golang.org>
    5b043abe
asm6.go 130 KB