• Keith Randall's avatar
    cmd/compile: print recursive types correctly · 5d8a61a4
    Keith Randall authored
    Change the type printer to take a map of types that we're currently
    printing. When we happen upon a type that we're already in the middle
    of printing, print a reference to it instead.
    
    A reference to another type is built using the offset of the first
    byte of that type's string representation in the result. To facilitate
    that computation (and it's probably more efficient, regardless), we
    print the type to a buffer as we go, and build the string at the end.
    
    It would be nice to use string.Builder instead of bytes.Buffer, but
    string.Builder wasn't around in Go 1.4, and we'd like to bootstrap
    from that version.
    
    Fixes #29312
    
    Change-Id: I49d788c1fa20f770df7b2bae3b9979d990d54803
    Reviewed-on: https://go-review.googlesource.com/c/go/+/214239Reviewed-by: default avatarRobert Griesemer <gri@golang.org>
    5d8a61a4
fmt.go 41.5 KB