• Matthew Dempsky's avatar
    cmd/compile: fix false positives in isGoConst · 7fa195c1
    Matthew Dempsky authored
    isGoConst could spuriously return true for variables that shadow a
    constant declaration with the same name.
    
    Because even named constants are always represented by OLITERAL nodes,
    the easy fix is to just ignore ONAME nodes in isGoConst. We can
    similarly ignore ONONAME nodes.
    
    Confirmed that k8s.io/kubernetes/test/e2e/storage builds again with
    this fix.
    
    Fixes #30430.
    
    Change-Id: I899400d749982d341dc248a7cd5a18277c2795ec
    Reviewed-on: https://go-review.googlesource.com/c/164319
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarRobert Griesemer <gri@golang.org>
    7fa195c1
issue30430.go 341 Bytes