Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • G go
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • go
  • Repository
  • go
  • src
  • database
  • sql
  • sql.go
Find file BlameHistoryPermalink
  • Daniel Theophanes's avatar
    database/sql: check for nil connRequest.conn before use · b98ffdf8
    Daniel Theophanes authored Mar 25, 2018
    The connRequest may return a nil conn value. However in a rare
    case that is difficult to test for it was being passed to
    DB.putConn without a nil check. This was an error as this
    made no sense if the driverConn is nil. This also caused
    a panic in putConn.
    
    A test for this would be nice, but didn't find a sane
    way to test for this condition.
    
    Fixes #24445
    
    Change-Id: I827316e856788a5a3ced913f129bb5869b7bcf68
    Reviewed-on: https://go-review.googlesource.com/102477
    
    
    Run-TryBot: Daniel Theophanes <kardianos@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: default avatarAlexey Palazhchenko <alexey.palazhchenko@gmail.com>
    Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
    b98ffdf8
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7