• Josh Bleecher Snyder's avatar
    cmd/compile: use named fields in nodl · e9285352
    Josh Bleecher Snyder authored
    We use a struct to allocate two structs simultaneously.
    Because we embed structs rather than using named fields,
    the compiler generates forwarding method stubs for the
    anonymous type.
    
    In theory, the compiler could detect that these stubs are unnecessary:
    The value in question has a very limited scope, the methods are not
    called, and there are operations where an interface would need
    to be satisfied.
    
    This compiler optimization is unlikely to happen, though;
    the ROI is likely to be low.
    
    Instead, just give the fields names. Cuts 64k off the cmd/compile binary.
    
    Change-Id: Id10ec69c23cd2dd33306f4c1bc75724e3c571b56
    Reviewed-on: https://go-review.googlesource.com/c/go/+/172579
    Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
    Reviewed-by: default avatarMatthew Dempsky <mdempsky@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    e9285352
subr.go 42.9 KB